In the set up of CustomErrorTestCas there is the following line of code

parent::setUp(array('variable', 'customerror'));

As the variable module is not a dependency and not in core, this causes the test to fail.

Status

Fixed in release 7.x-1.1.

Comments

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
CreditAttribution: gisle commented

Thanks for reporting this. You're right about the Variable module not being a dependency.

However, just removing the Variable module from the setUp array is not sufficient. Looking at the code, I believe several of the test cases committed in May 2013 are out of place, or just wrong. It looks like the test cases needs to be reviewed again.

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
CreditAttribution: gisle commented
Related issues: +#1430584: Test cases are broken

The test cases were reviewed and added in May 2013. Looks like they need a new review.

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
CreditAttribution: gisle commented
Assigned: Unassigned » gisle
Issue summary: View changes
Status: Active » Needs review

Fixed in latest dev release. Please review.

Kionn’s picture

Kionn CreditAttribution: Kionn commented

Yes, it's fixed. The test passes now.

  • Commit 88ea493 on 7.x-1.x, 8.x-1.x by gisle: 
    #2136653 by gisle: Fixed broken test cases.
gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
CreditAttribution: gisle commented
Version: 7.x-1.x-dev » 7.x-1.1
Issue summary: View changes
Status: Needs review » Fixed

Fixed in release 7.x-1.1.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.