As of #731724: Convert comment settings into a field to make them work with CMI and non-node entities, comment settings are a field. When rendered, you get to see the actual comments plus possibly the comment form. However, to Edit module, this is just another field; it has no way of knowing that this in fact not a field with actual editable content. So it marks the stuff CommentDefaultFormatter outputs as in-place, by setting a data-edit-field-id attribute on it.

Consequently, there is a bizarre blue bar (which is actually the "comment field" being marked as in-place editable) at the bottom of the page when in-place editing, that clearly makes in-place editing look broken:

The solution is to set edit.editor = "disabled" in CommentDefaultFormatter's annotation: that tells Edit that this field formatter does not support in-place editing at all. Result:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers’s picture

Issue summary: View changes
Issue tags: +quickfix
FileSize
730 bytes

Et voila. Très simple.

jessebeach’s picture

Status: Active » Reviewed & tested by the community

Nice! A simple patch that keeps the comment field from being processed for in place edit.

This patch made me look again at why we are hiding the comments during in place editing. I decided to see if we could keep them visible. The reason they are hidden is due to the placement algorithm of the Entity Toolbar, so I updated this #2137005: Don't hide comments during in-place editing of an Article; position the entity toolbar more intelligently.

larowlan’s picture

Thanks, great catch - +1

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Nice, I saw this pop up in demos fairly recently and wasn't sure where it was coming from.

Committed and pushed to 8.x. Thanks!

Wim Leers’s picture

Issue tags: -sprint

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.