No scrollbar in views style option popup

Given that this potentially affect a lot of forms I consider this major.

This code should be getting run on all these dialogs, but it was conditional on the existance of a data-drupal-views-offset element . You can see that this element is on some of the dialogs but not others. Look for some empty space under the title of a dialog that slightly increases the height of the grey area the title is on. I'm not sure if the intent is for it to only appear on some dialogs, it seems inconsistant.

This patch removes the check, but it may be better to make sure all the dialogs have this element instead.

Tagging for JS maintainers

I think this solution is not satisfying, because:

• when the bottom of the modal is reached, the body scrolls. This is a little bit annoying. Might be fixed with a „overflow: hidden“ for the body as long as the modal is open
• when you select „table“ you have to scroll vertical AND horizontal in the following modal window (see screenshot). The width of the modal should adapt the content width if the viewport is wide enough.

This patch fixes the scrolling of the body when the modal is open but i don’t know how to fix the width of the modal when it’s content is bigger.

Also affects Row style options dialog

Steps:
1. Create a website on simplytest.me using alpha14
2. Click manage
3. Click views
4. Click Add new view
5. View name test
6. Check Create a page
7. Click Save and edit
8. For show, click Content
9. Select Fields
10. Click Apply

Actual results: Page: Row style options dialog text gets cut off, but there is content.

Workaround: Tab to any off-screen fields. However, if there is any section of text between tabable fields that is taller than the dialog box makes available for text, this workaround would not be sufficient.

This issue would be exacerbated if text is zoomed in for low-vision users, so adding the accessibility tag.

Repeated your just fine @Charles Belov, thanks.

Any suggestion on how to repeat the example given by @MartiMcFlight in #6?

It would be great if someone would have an idea how to fix it properly :)

I cannot reproduce the error in 8.0-beta9. I followed the issuers steps and the steps in #9.

Still happening in dev.

We only want to have the change in dialog.views.js no change on the body so patch #3 is the way to go. Can someone reroll/reup the patch?

#6.1: it's how it is, we considered doing something like that but decided against when implementing the original dialog API. We can discuss again if you feel there is a need but it's a new issue, nothing to do with this bug.
#6.2: feature request, should be a new issue.

I'm also still seeing this issue on HEAD. Applying the patch in #3 fixes the issue. While it would be nice to have, I don't think we have to fix the issue where the rest of the page scrolls when you get to the bottom of the dialog content. That's the current behaviour in D7 views. Maybe open a follow up for that, as I agree would be nice.

Also, that patch in #3 does apply cleany against HEAD, so no-need for re-roll.

if still applies, please reup. It's easier for core committers when the patch to apply is always the last one.

Ahh, I see, sorry about that, new to core dev, didn't know what you meant. Here's a reup of #3 :).

Before and after Screenshots

+1 RTBC

This issue addresses a major bug and is allowed per https://www.drupal.org/core/beta-changes. Committed 28f3002 and pushed to 8.0.x. Thanks!