Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
The addition of the slideshow JS is done in a bare top-level conditional in template.php.
This makes it impossible for a sub-theme to change that behavior.
Comment | File | Size | Author |
---|---|---|---|
#5 | 2137903-5.patch | 1.69 KB | pwolanin |
#3 | template-include-slider-js.patch | 2.72 KB | mheinke |
Comments
Comment #1
mheinke CreditAttribution: mheinke commented@pwolanin agreed, how do you suggest we change that?
Comment #2
mheinke CreditAttribution: mheinke commentedComment #3
mheinke CreditAttribution: mheinke commentedadded the calls to the professional_theme_preprocess_page hook in template.php here is a patch please confirm
Comment #4
pwolanin CreditAttribution: pwolanin commentedlooks like it's using tabs rather than 2 spaces?
Also, can you add the JS using #attached?
Comment #5
pwolanin CreditAttribution: pwolanin commentedArgh, #attached wasn't working for me for some reason. If I have a chance I'll ping nod_ or someone else who knows more about it.
Anyhow, here's one that does it with less change in spacing, plus gets rid of hook_page_alter by moving the addition of the viewport to the preprocess.
Comment #6
mheinke CreditAttribution: mheinke commentedthanks for the patch! im going to make sure it applys cleanly, test it in simplytest.me, then i will push it to 7.x-2.x and give you credit :)
Comment #7
mheinke CreditAttribution: mheinke commentedapplied cleanly, code looks good, and it runs in a clean instance! i have added it to the 7.x-2.x repo to test please pull the latest from git.
Comment #8
mheinke CreditAttribution: mheinke commentedComment #9
mheinke CreditAttribution: mheinke commented