The addition of the slideshow JS is done in a bare top-level conditional in template.php.

This makes it impossible for a sub-theme to change that behavior.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mheinke’s picture

@pwolanin agreed, how do you suggest we change that?

mheinke’s picture

Assigned: Unassigned » mheinke
Priority: Normal » Major
Status: Active » Needs work
mheinke’s picture

Status: Needs work » Needs review
FileSize
2.72 KB

added the calls to the professional_theme_preprocess_page hook in template.php here is a patch please confirm

pwolanin’s picture

looks like it's using tabs rather than 2 spaces?

Also, can you add the JS using #attached?

pwolanin’s picture

FileSize
1.69 KB

Argh, #attached wasn't working for me for some reason. If I have a chance I'll ping nod_ or someone else who knows more about it.

Anyhow, here's one that does it with less change in spacing, plus gets rid of hook_page_alter by moving the addition of the viewport to the preprocess.

mheinke’s picture

thanks for the patch! im going to make sure it applys cleanly, test it in simplytest.me, then i will push it to 7.x-2.x and give you credit :)

mheinke’s picture

Status: Needs review » Patch (to be ported)

applied cleanly, code looks good, and it runs in a clean instance! i have added it to the 7.x-2.x repo to test please pull the latest from git.

mheinke’s picture

Status: Patch (to be ported) » Closed (fixed)
mheinke’s picture

Status: Patch (to be ported) » Closed (fixed)