Updated: Comment #0

Problem/Motivation

Config Translation's route subscriber is not unit tested.

Proposed resolution

Unit test it!

Remaining tasks

User interface changes

None.

API changes

None.

CommentFileSizeAuthor
#10 2139135-10.patch4.32 KBYesCT
#1 2139135-1.patch4.36 KBtstoeckler
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Active » Needs review
FileSize
2139135-1.patch4.36 KB

Yes, I want to translate my pets with Drupal. :-)

I included two doc fixes in the other unit test classes, please don't kill me.

Status: Needs review » Needs work

The last submitted patch, 1: 2139135-1.patch, failed testing.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Needs work » Needs review

1: 2139135-1.patch queued for re-testing.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Issue tags: +Random fail

StreamWrapperTest.php, line 95

Status: Needs review » Needs work

The last submitted patch, 1: 2139135-1.patch, failed testing.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Needs work » Needs review

Just had this very strange random fail in #1792310: Wrong DRUPAL_ROOT with non-standard code structure as well:

ImageFieldDisplayTest.php, line 229
ImageFieldDisplayTest.php, line 251

array_flip(): Can only flip STRING and INTEGER values!
in FieldableDatabaseStorageController.php, line 212

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented

1: 2139135-1.patch queued for re-testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented 
  1. +++ b/core/modules/config_translation/tests/Drupal/config_translation/Tests/Routing/RouteSubscriberTest.php
@@ -0,0 +1,100 @@
+ * Tests RouteSubscriber.

    Just in case you reroll that patch, let's actually describe which class we test 

  2. +++ b/core/modules/config_translation/tests/Drupal/config_translation/Tests/Routing/RouteSubscriberTest.php
@@ -0,0 +1,100 @@
+class RouteSubscriberTest extends UnitTestCase {
...
+      'name' => 'Configuration entity mapper',
+      'description' => 'Tests the functionality provided by the configuration entity mapper.',
+      'group' => 'Configuration Translation',

    Some of those lines might disagree, in other words I would love to get rid of getInfo() for unit tests. 

  3. +++ b/core/modules/config_translation/tests/Drupal/config_translation/Tests/Routing/RouteSubscriberTest.php
@@ -0,0 +1,100 @@
+    foreach (array('cat', 'dog') as $plugin_id) {
...
+      foreach (array(

    Should this code be moved to a dataProvider?

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Issue tags: -Random fail +Random test failure
YesCT’s picture

YesCT CreditAttribution: YesCT commented
FileSize
2139135-10.patch4.32 KB

rerolled this to apply (auto 3-way merge)
but phpunit fails

-----------
./vendor/bin/phpunit --group Config_translation
PHPUnit 3.7.21 by Sebastian Bergmann.

Configuration read from /Users/ctheys/foo/drupal/core/phpunit.xml.dist

........................................................
Fatal error: Call to undefined method Drupal\config_translation\Routing\RouteSubscriber::routes() in /Users/ctheys/foo/drupal/core/modules/config_translation/tests/Drupal/config_translation/Tests/Routing/RouteSubscriberTest.php on line 95

YesCT’s picture

YesCT CreditAttribution: YesCT commented

#2145041: Allow dynamic routes to be defined via a callback

-  protected function routes(RouteCollection $collection) {
+  protected function alterRoutes(RouteCollection $collection, $provider) {
YesCT’s picture

YesCT CreditAttribution: YesCT commented
Issue tags: +D8MI

Status: Needs review » Needs work

The last submitted patch, 10: 2139135-10.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Issue tags: -Random test failure

The issue tag is for issues to fix random test failures, not for affected issues.

#2262085: Random test failure in Drupal\image\Tests\ImageFieldDisplayTest

If you encounter a random test failure, please create a dedicated bug report for the random test failure + tag it + copy the testbot assertion failures into its issue summary.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Assigned: tstoeckler » Unassigned

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.