As #1504696: Integration with CKEditor module was [rightfully :)] moved to the Media queue, the current media plugin included with CKEditor should be removed. The CKEditor media plugin is stale/out-of-date, is using the "media" namespace and has resulted in a large number of support requests in the Media issue queue (users enable the CKEditor media plugin instead of the WYSIWYG plugin and wonder why things are missing/aren't working).

CommentFileSizeAuthor
#1 remove-media-plugin-2140155-1.patch17.47 KBDevin Carlson
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Devin Carlson’s picture

Devin Carlson CreditAttribution: Devin Carlson commented
Status: Active » Needs review
FileSize
remove-media-plugin-2140155-1.patch17.47 KB

A patch to remove the media plugin.

jcisio’s picture

jcisio CreditAttribution: jcisio commented

Thanks for the patch. I think it will be a necessary clean up when 1/ Media 2.x have a 2.0 release, and 2/ They dropped support for Media 1.x. At the moment we can't have make a backward incompatible step.

If the plugin is "stale/out-of-date", i.e. does not work with Media 1.x, then it is a bug and needs to be fixed.

wwalc’s picture

wwalc CreditAttribution: wwalc commented

+1 after #2159403: Make CKEditor plugin system modular and clean is closed.

deggertsen’s picture

deggertsen CreditAttribution: deggertsen commented
Status: Needs review » Needs work

Patch doesn't apply correctly to dev with the patch from #2159403: Make CKEditor plugin system modular and clean.

Maybe this even needs to be postponed until #2159403: Make CKEditor plugin system modular and clean is committed.

jcisio’s picture

jcisio CreditAttribution: jcisio commented
Status: Needs work » Postponed
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer commented
Status: Postponed » Closed (duplicate)
Related issues: +#2542566: Remove Media integration

I think we should mark this as a duplicate of #2542566: Remove Media integration now.

OnkelTem’s picture

OnkelTem CreditAttribution: OnkelTem as a volunteer commented

Please can anybody explain — what to use now after this plugin is removed?

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
CreditAttribution: saltednut at Acquia commented

@OnkelTem CKEditor now has a plugin system and Media module 2.x provides its own plugin. So this original one needs to be removed as its an old implementation. Currently, it shows up as a duplicate checkbox in the configuration UI.

OnkelTem’s picture

OnkelTem CreditAttribution: OnkelTem as a volunteer commented

@brantwynn

Thanks for the quick reply. In my setup I have Media 2.0 and CKEditor 7.16. The problem is that inserting images via Media doesn't work: after I click toolbar button and select an image from the Library, I get error message:

The requested page "/media/31/format-form?render=media-popup&fields=undefined" could not be found.

I actually found an issue where people reporting this: #2138953-8: Provide support for CKEditor module but it seems a bit outdated.