I ran this module through coder review and it had a few really minor suggestions. I've cleaned them up and now coder passes 100%.

Here is the list of items it wanted fixed (all spacing related):

1. Line 328: Use "elseif" in place of "else if"

else if ($error['error_element']['url']) {

2. Line 707: String concatenation should be formatted with a space separating the operators (dot .) and the surrounding terms

$output .= '

';

3. Line 1208: String concatenation should be formatted with a space separating the operators (dot .) and the surrounding terms

$email_pattern = '/^mailto:' . $user . '@'.'(?:' . $domain . '|' . $ipv4 . '|' . $ipv6 . '|localhost)' . $query . '?$/';

CommentFileSizeAuthor
#1 link-coder_review-2141643.patch1.65 KBzhuber
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

zhuber’s picture

Assigned: zhuber » Unassigned
Status: Needs work » Needs review
FileSize
1.65 KB

Here is the patch.

jcfiala’s picture

Status: Needs review » Fixed

Thanks! Okay, this is merged in.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.