I ran this module through coder review and it had a few really minor suggestions. I've cleaned them up and now coder passes 100%.
Here is the list of items it wanted fixed (all spacing related):
1. Line 328: Use "elseif" in place of "else if"
else if ($error['error_element']['url']) {
2. Line 707: String concatenation should be formatted with a space separating the operators (dot .) and the surrounding terms
$output .= '
'. drupal_render($element['url']) . '';
3. Line 1208: String concatenation should be formatted with a space separating the operators (dot .) and the surrounding terms
$email_pattern = '/^mailto:' . $user . '@'.'(?:' . $domain . '|' . $ipv4 . '|' . $ipv6 . '|localhost)' . $query . '?$/';
Comment | File | Size | Author |
---|---|---|---|
#1 | link-coder_review-2141643.patch | 1.65 KB | zhuber |
Comments
Comment #1
zhuber CreditAttribution: zhuber commentedHere is the patch.
Comment #2
jcfiala CreditAttribution: jcfiala commentedThanks! Okay, this is merged in.