Add smtp validating on mail addresses [#2141753]

Added a function smtp_validate_addresses($fromAddress = FALSE, $toAddresses = array()) to validate mail addresses via stmp RCPT TO:<$toADDRESS>

Some mail addresses are not accepted by smtp, so if sometimes we need to validate them before really send mails.

Comment	File	Size	Author
#7	interdiff-2141753-4-6.txt	815 bytes	Anonymous (not verified)
#6	interdiff-2141753-4-5.txt	814 bytes	jordanpagewhite
#6	smtp-n2141753-5.patch	3.19 KB	jordanpagewhite
#6	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 2 pass
#5	Screen shot 2016-01-30 at 8.31.40 PM.png	62.79 KB	Anonymous (not verified)
#5	Screen shot 2016-01-30 at 9.29.17 PM.png	27.01 KB	Anonymous (not verified)
#4	smtp-n2141753-4.patch	3.19 KB	DamienMcKenna
#4	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 2 pass
#2	2141753-smtp-validating.patch	4.71 KB	rogical
#2
#1	smtp-validating.patch	3.21 KB	rogical
#1
	smtp-validating.patch	3.29 KB	rogical

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

rogical CreditAttribution: rogical commented 25 December 2013 at 02:19

File	Size
smtp-validating.patch	3.21 KB

1 file was hidden/shown/deleted

File	Size
smtp-validating.patch	3.29 KB

Instead of throwing an scare exception, just return the error directly.

Comment #2

rogical CreditAttribution: rogical commented 17 January 2014 at 02:17

File	Size
2141753-smtp-validating.patch	4.71 KB

Comment #3

mgifford

he/him

English

CreditAttribution: mgifford commented 20 January 2015 at 20:18

This still applies nicely (one year after you submitted it).

How do we test this patch? I don't presently need this functionality myself, but can see how it could be useful.

Comment #4

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna as a volunteer commented 25 January 2016 at 11:56

File	Size
smtp-n2141753-4.patch	3.19 KB
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 2 pass

2 files were hidden/shown/deleted

File	Size
smtp-validating.patch	3.21 KB

2141753-smtp-validating.patch	4.71 KB

Rerolled, and I removed the unnecessary changes from PHPMailer->SmtpConnect().

Comment #5

Anonymous (not verified) CreditAttribution: Anonymous as a volunteer and commented 31 January 2016 at 02:37

File	Size
Screen shot 2016-01-30 at 9.29.17 PM.png	27.01 KB
Screen shot 2016-01-30 at 8.31.40 PM.png	62.79 KB

Looks good to me. I rolled the patch and it applied perfect. Seems legit to me. Let me know if you want to to test this one further. I am going to work on another one on the list.

Comment #6

jordanpagewhite CreditAttribution: jordanpagewhite as a volunteer commented 31 January 2016 at 07:15

File	Size
smtp-n2141753-5.patch	3.19 KB
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 2 pass
interdiff-2141753-4-5.txt	814 bytes

Looks good. I think I caught two typos. Check the interdiff.

Comment #7

Anonymous (not verified) CreditAttribution: Anonymous as a volunteer and commented 1 February 2016 at 04:23

File	Size
interdiff-2141753-4-6.txt	815 bytes

I see your two typos and raise you one typo.

- return t('The from mail address: !fromAddress is not accpted by the SMTP server.', array('!fromAddress' => $fromAddress));

- return t('The from mail address: !fromAddress is not accepted by the SMTP server.', array('!fromAddress' => $fromAddress));

Comment #8

Anonymous (not verified) CreditAttribution: Anonymous as a volunteer and commented 1 February 2016 at 04:24

Comment #9

jordanpagewhite CreditAttribution: jordanpagewhite as a volunteer commented 1 February 2016 at 04:33

@alex_drupal_dev Hmm. The only difference that I can see between my interdiff and your interdiff is that yours has the correct spelling of "accepted" in the "-" line of the second edit. Did you generate this yourself or did you just edit my interdiff? If you generated it, I think we were working from different versions of the module. If you just edited my interdiff, you can read how to generate an interdiff here https://www.drupal.org/documentation/git/interdiff

Comment #10

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna as a volunteer commented 1 February 2016 at 10:58

4 files were hidden/shown/deleted

File	Size
Screen shot 2016-01-30 at 9.29.17 PM.png	27.01 KB
Screen shot 2016-01-30 at 8.31.40 PM.png	62.79 KB
interdiff-2141753-4-5.txt	814 bytes
interdiff-2141753-4-6.txt	815 bytes

The interdiff in #7 is redundant and can be ignored. +1 for the patch in #6.

Comment #11

Anonymous (not verified) CreditAttribution: Anonymous as a volunteer and commented 2 February 2016 at 23:01

LOL. Just an edit for the typo. Thanks for the link I will definitely use it. :) Just keeping things fun :) I appreciate the link I will practice creating some later tonight :)