Closed (fixed)
Project:
Security Review
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
23 Nov 2013 at 13:26 UTC
Updated:
21 Jun 2014 at 21:20 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
coltraneHello. I'm not able to reproduce this on a fresh Drupal 7.24 installation. Could you provide some more information on your site, such as what modules you are using.
If you would please try a drupal cache clear and also running the security review not within the overlay page (visit admin/reports/security-review directly).
Also, are there any error messages for security review or batch in the logs?
Comment #2
tim042849 commentedI'm finding problems also. When using drush to push content sql-sync would fail with
Running updb gave me a clue
And removing (not just disabling the module cured the problem (I think).
Also, upon upgrading to 7.24 got all kinds of *wrong* error messages for security review - it seemed to be reading file permissions incorrectly.
Module list follows
Comment #3
ray field commentedsimilar problems here. every time I try to use Drush to update my Drupal site, it fails -- for instance, "drush up" yields:
if I go into Site Administration and disable the Security Review module, Drush works just fine.
Comment #4
tim042849 commentedThe lack of response is alarming. I hate to sound like a ranter, but
alarming is an appropriate word, IMHO it needs to be said ...
Comment #5
coltraneThe require_once is bad since it'll halt PHP so attached patch changes it to a include_once and will drush_set_error() out of the command if the file isn't loaded.
I've not been able to reproduce this problem so perhaps its some specific thing with PHP. Try this patch out and let me know how it goes.
Comment #6
coltraneComment #7
tim042849 commentedMy thanks to coltrane for the patch. I have applied it to my local workstation copy of my site. I am no longer seeing the errors as noted above and that is good news! I have run the security review report and am trying to grok some things before pushing it to the server. I will add another comment detailing any (if any) issues once it is deployed.
-- regards
tim --
Comment #8
coltraneCommitted and pushed http://drupalcode.org/project/security_review.git/commit/a9307dc.
Comment #10
webservant316 commentedDrupal 7.x requires up to PHP 5.2.x and __DIR__ is not defined in PHP 5.2.x. The patch needs to be improved so that security_review.inc is still included when using PHP 5.2.x.
Comment #11
webservant316 commentedTry this patch instead and hopefully this gets included in the latest dev.
Comment #13
webservant316 commentedsorry folks, I do not have the tools to make a proper patch. however the patch in #5 would be improved with these lines instead....
Comment #14
coltraneI like dirname(__FILE__) better than a conditional. Try this patch out.
Comment #15
coltraneCommitted http://drupalcode.org/project/security_review.git/commit/7e0592a