Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.After removing disabled modules in #1199946: Disabled modules are broken beyond repair so the "disable" functionality needs to be removed the option to check for translation updates of disabled modules doesn't make sense anymore. The translation of an uninstalled module will be updated when the module will be enabled anyway. Therefore it is obsolete to check for translation updates of modules in between.
Talking to Gábor we figured that updating the translation of disabled themes doesn't really cover a common - if any - use case.
The option " Check for updates of disabled modules and themes" on the user interface translation settings page and related functionality should be removed therefore.
| Comment | File | Size | Author |
|---|---|---|---|
| #16 | 2143093-diff-14-16.txt | 1.37 KB | vijaycs85 |
| #16 | 2143093-remove-translation-16.patch | 6.98 KB | vijaycs85 |
| #14 | 2143093-diff-12-14.txt | 1.26 KB | vijaycs85 |
| #14 | 2143093-remove-translation-14.patch | 5.61 KB | vijaycs85 |
| #12 | 2143093-remove-translation-12.patch | 4.77 KB | vijaycs85 |
Comments
Comment #1
Gábor HojtsyYeah uninstalled modules seem to be foolish to cover, that was definitely not the original intention.
Comment #2
fubhy CreditAttribution: fubhy commentedYep. I think we even temporarily removed this in the patch for https://drupal.org/node/1199946 but then purged that from the patch as we were not sure about it and didn't want to increase the size of the patch even further and give more room for controversies. Thinking about it again though it's definitely something we can remove as it makes zero sense. We actually changed the functionality of this with https://drupal.org/node/1199946 as it now covers "uninstalled" modules (which is something it didn't do before). So we really should've removed it with that patch...
So definitely +1 from me.
Comment #3
Gábor HojtsyTalked to @Sutharsan and he liked the idea of this issue. Here is an initial patch. I looked at removing the setting and all related code. Then looked at whether the project status column should be removed from the database (and all code maintaining that). *However* locale is additive. Translation files are imported but when a module is uninstalled, we don't remove the translations. So it makes most sense to keep the project status / file status information, so if you reinstall a module, we know if the translation needs an update or not. The translations will be in the database the whole time.
So only removing the option and the conditions around it and keeping the filter to only check for installed/enabled projects.
Comment #5
Gábor Hojtsy3: remove-check-disabled.patch queued for re-testing.
Comment #7
Gábor Hojtsy3: remove-check-disabled.patch queued for re-testing.
Comment #9
k4v CreditAttribution: k4v commentedI just looked into this, not shure why this fails. Will do some more debugging tomorrow, Test runs locally for 15 mins... :/
Comment #10
k4v CreditAttribution: k4v commented3: remove-check-disabled.patch queued for re-testing.
Comment #12
vijaycs85Re-rolling...
Comment #14
vijaycs85Seems the config save hasn't been saving inside switch().
Comment #16
vijaycs85Removing the test case related to disabled module check...
Comment #17
fubhy CreditAttribution: fubhy commentedThanks Vijay!
I think we should to update the disabled modules removal change notice for this one.
Comment #18
Gábor HojtsyOh great find, that since we removed the config change for the disabled modules, the prior settings were not saved either :D Haha. +1 on RTBC.
Comment #19
Gábor HojtsyComment #20
webchickGreat clean-up!
Committed and pushed to 8.x. Thanks!
Comment #21
Gábor HojtsyYay for more consistency :)
Comment #23
asb CreditAttribution: asb commentedAre there any plans to backport the "Remove translation update for uninstalled modules and themes" functionality to D6/D7?
Should I open a new issue for this question?
Thanks!
Comment #24
kopeboy CreditAttribution: kopeboy commentedPlease can we have this backported to Drupal 7?
The locales tables are around 20% of the database size of any website I make, and 90% of those string are useless to me, i.e. string that I don't need to translate but where created and imported automatically.
Not counting the performance hit...
Comment #27
Gábor Hojtsy