Missing checkout views

I believe I found the issue, and it's twofold:

1) I had loaded the new module code on top of the old, meaning there were still some leftover crufty Views defaults there.

2) The variable "commerce_coupon_review_pane_view" needs to be deleted from the database, because the old Coupon module had set this variable and the new 2.x still does reference it. This means an upgrade path will need to simply remove this variable and remove/disable the old pane view.

Everything else worked fine, though, after uninstalling 1.x and re-installing a clean 2.x.

For completeness: I installed commerce_coupon 2.x 'new' (i.e. after completely uninstalling 1.x), and everything works fine. So it's an update issue.

The view name is not directly referenced, but through a variable. So that variable value should be updated. I guess it should only be updated if the "commerce_coupon_review_pane" is actually not present anymore, so that leads to the uploaded patch.

Note #1: I spotted that the update functions are incorrectly numbered (now that this is actually the 2.x branch). So included that in the same patch.

Note/question #2: Why are we actually renaming the view from 'commerce_coupon_review_pane' to 'order_coupon_list'?

If not, this new update isn't necessary. But obviously I only ask myself this question after coding it... :)

Meh, crosspost. I'm too slow for this; was coding/testing a patch before commenting, but missed your conversation in the meantime :)

Here's a quick reroll that works in the site I'm tinkering with (after I manually changed the variable settings back). The .install patch that I picked up along the way, is split into a separate file.

Failed to change the first comment line in patch 5a.

This is pretty old and I am reasonably sure the problem has been fixed. I am going to close for now.