Coder suggested some simple formatting changes. I am doing the clean-up and will upload my patch here.
Here are the suggestions from coder:
Line 144: Use "elseif" in place of "else if" [style_elseif]
else if (function_exists($data['hook theme'])) {
severity: normalreview: style_elseifLine 222: Use "elseif" in place of "else if" [style_elseif]
else if (function_exists($data['hook menu'])) {
severity: normalreview: i18n_0Line 273: The $text argument to l() should be enclosed within t() so that it is translatable. [i18n_0]
'description' => t("Allows a user to access the !link.", array('!link' => l('Panels Dashboard', 'admin/structure/panels'))),
severity: normalreview: style_string_spacingLine 1041: String concatenation should be formatted with a space separating the operators (dot .) and the surrounding terms [style_string_spacing]
$output .= "$prefix " . '$display->panels[\'' . $pane->panel . '\'][' . $region_counters[$pane->panel]++ .'] = \'' . $pane->pid . "';\n";
severity: normalreview: style_uppercase_constantsLine 1162: Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE [style_uppercase_constants]
$image = l(theme('image', array('path' => $file)), $link, array('html' => true) + $options);
severity: normalreview: style_control_spacingLine 1233: Control statements should have one space between the control keyword and opening parenthesis [style_control_spacing]
if(!empty($element['#links'])) {
severity: normalreview: style_string_spacingLine 1260: String concatenation should be formatted with a space separating the operators (dot .) and the surrounding terms [style_string_spacing]
$type_class = $content->type ? 'pane-'. ctools_cleanstring($content->type, array('lower case' => TRUE)) : '';
severity: normalreview: style_string_spacingLine 1261: String concatenation should be formatted with a space separating the operators (dot .) and the surrounding terms [style_string_spacing]
$subtype_class = $content->subtype ? 'pane-'. ctools_cleanstring($content->subtype, array('lower case' => TRUE)) : '';
Comment | File | Size | Author |
---|---|---|---|
#1 | panels-coder_cleanup-2143815.patch | 3.31 KB | zhuber |
Comments
Comment #1
zhuber CreditAttribution: zhuber commentedHere is the patch. Coder now passes 100% for the panels module.
If this patch is committed, can you please try to attribute the commit correctly? I've been having issues with this when supplying patches for various modules. (http://www.bywombats.com/blog/09-06-2011/giving-credit-where-credit-due)
Thanks
Comment #2
jacob.embree CreditAttribution: jacob.embree commented#1 does not apply.