Coder suggested some simple formatting changes. I am doing the clean-up and will upload my patch here.

Here are the suggestions from coder:

Line 144: Use "elseif" in place of "else if" [style_elseif]
else if (function_exists($data['hook theme'])) {
severity: normalreview: style_elseif

Line 222: Use "elseif" in place of "else if" [style_elseif]
else if (function_exists($data['hook menu'])) {
severity: normalreview: i18n_0

Line 273: The $text argument to l() should be enclosed within t() so that it is translatable. [i18n_0]
'description' => t("Allows a user to access the !link.", array('!link' => l('Panels Dashboard', 'admin/structure/panels'))),
severity: normalreview: style_string_spacing

Line 1041: String concatenation should be formatted with a space separating the operators (dot .) and the surrounding terms [style_string_spacing]
$output .= "$prefix " . '$display->panels[\'' . $pane->panel . '\'][' . $region_counters[$pane->panel]++ .'] = \'' . $pane->pid . "';\n";
severity: normalreview: style_uppercase_constants

Line 1162: Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE [style_uppercase_constants]
$image = l(theme('image', array('path' => $file)), $link, array('html' => true) + $options);
severity: normalreview: style_control_spacing

Line 1233: Control statements should have one space between the control keyword and opening parenthesis [style_control_spacing]
if(!empty($element['#links'])) {
severity: normalreview: style_string_spacing

Line 1260: String concatenation should be formatted with a space separating the operators (dot .) and the surrounding terms [style_string_spacing]
$type_class = $content->type ? 'pane-'. ctools_cleanstring($content->type, array('lower case' => TRUE)) : '';
severity: normalreview: style_string_spacing

Line 1261: String concatenation should be formatted with a space separating the operators (dot .) and the surrounding terms [style_string_spacing]
$subtype_class = $content->subtype ? 'pane-'. ctools_cleanstring($content->subtype, array('lower case' => TRUE)) : '';

CommentFileSizeAuthor
#1 panels-coder_cleanup-2143815.patch3.31 KBzhuber
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

zhuber’s picture

Status: Needs work » Needs review
FileSize
3.31 KB

Here is the patch. Coder now passes 100% for the panels module.

If this patch is committed, can you please try to attribute the commit correctly? I've been having issues with this when supplying patches for various modules. (http://www.bywombats.com/blog/09-06-2011/giving-credit-where-credit-due)

Thanks

jacob.embree’s picture

Status: Needs review » Needs work

#1 does not apply.