project_dependency is failing to clone easycron for calculations.

This has nothing to do with project_dependency - a clone just fails:

rfay@rfay-macbook2013:/tmp$ git clone git://git.drupal.org/project/easycron.git
Cloning into 'easycron'...
fatal: remote error: access denied or repository not exported: /project/easycron.git

However, easycron shows releases... https://drupal.org/project/easycron

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rfay’s picture

Title: Unable to clone easycron project » Unable to git clone easycron project
eliza411’s picture

I can clone this on my local environment both anonymously and as a maintainer, fwiw.

rfay’s picture

Turns out this is one of those case problems.

The shortname of the project is easycron, but the repository is EasyCron.git

So I *can* clone EasyCron.

drumm’s picture

Project: Drupal.org infrastructure » Project Dependency
Version: » 7.x-1.x-dev
Component: Git » Code

https://drupal.org/project/EasyCron/git-instructions does show EasyCron.git. Machine names are not the same as repository names.

In project_dependency_get_external_component_dependencies()

          $dependency_releases[$dependency_component] = array(
            'uri' => $machine_name,

$machine_name should be something like $project->versioncontrol_project['repo']->name.

In general, project_dependency.drupal.inc's project_dependency_info_batch_process_release() can be simplified by using more data from $project->versioncontrol_project.

drumm’s picture

This is surfacing after the D7 upgrade because we snuck lowercasing project machine names into the upgrade, but not lowercasing repo names.

trobey’s picture

Status: Active » Needs review
FileSize
1.2 KB

Attached is a patch. I tested it with

drush pdpp easycron

which is no longer failing.

rfay’s picture

Status: Needs review » Reviewed & tested by the community

Looks perfectly reasonable to me.

trobey’s picture

Status: Reviewed & tested by the community » Closed (fixed)
rfay’s picture

Status: Closed (fixed) » Fixed

Goes to "fixed" on commit. Commit was http://drupalcode.org/project/project_dependency.git/commitdiff/cda7962bb3

This will get deployed with the info.yml deployment.

rfay’s picture

Deployed on drupal.org

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.