Coder suggested some simple formatting changes. I am doing the clean-up and will upload my patch here.

Here are the suggestions from coder:

File: @file block missing (Drupal Docs) [comment_docblock_file]

Line 95: Functions should be called with no spaces between the function name and opening parentheses [style_function_spacing]
'#default_value' => isset ($settings['country']) ? $settings['country'] : NULL,

Line 232: Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs) [security_fapi_title]
'#title' => $element['#title'],

Line 233: Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs) [security_fapi_title]
'#description' => $element['#description'],

Line 295: String concatenation should be formatted with a space separating the operators (dot .) and the surrounding terms [style_string_spacing]
$dir = drupal_get_path('module', 'phone'). '/tests';

Line 328: String concatenation should be formatted with a space separating the operators (dot .) and the surrounding terms [style_string_spacing]
$phone_info_function = 'phone_'. $countrycode . '_metadata';

Line 329: String concatenation should be formatted with a space separating the operators (dot .) and the surrounding terms [style_string_spacing]
module_load_include('inc', 'phone', 'include/phone.'. $countrycode);

Line 352: String concatenation should be formatted with a space separating the operators (dot .) and the surrounding terms [style_string_spacing]
$valid_phone_function = 'valid_'. $countrycode . '_phone_number';

Line 353: String concatenation should be formatted with a space separating the operators (dot .) and the surrounding terms [style_string_spacing]
module_load_include('inc', 'phone', 'include/phone.'. $countrycode);

Line 376: String concatenation should be formatted with a space separating the operators (dot .) and the surrounding terms [style_string_spacing]
$format_phone_function = 'format_'. $countrycode . '_phone_number';

Line 377: String concatenation should be formatted with a space separating the operators (dot .) and the surrounding terms [style_string_spacing]
module_load_include('inc', 'phone', 'include/phone.'. $countrycode);

CommentFileSizeAuthor
#2 phone-coder_cleanup-2144837.patch3.41 KBzhuber
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

zhuber’s picture

Assigned: zhuber » Unassigned
Status: Needs work » Needs review

.

zhuber’s picture

Here is the patch, the phone module now passes through coder 100%.

If this patch is committed, please attribute correctly. (http://www.bywombats.com/blog/09-06-2011/giving-credit-where-credit-due)

Here is my author info:
--author="zhuber <zhuber@1437276.no-reply.drupal.org>"