when the block is activated, and are in page /booking we will find duplicate #rooms-wrapper id. Work around is to configur the block Visibility settings or replace these attribute to class? For the latter, here is the patch.

CommentFileSizeAuthor
#5 rooms-unique-id-for-search-block-2145081-5.patch1.19 KBjwilson3
#3 rooms-2145081-1.patch1.17 KBItangSanjana
#1 rooms-2145081-0.patch1.17 KBItangSanjana
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ItangSanjana’s picture

ItangSanjana CreditAttribution: ItangSanjana commented
FileSize
rooms-2145081-0.patch1.17 KB
ItangSanjana’s picture

ItangSanjana CreditAttribution: ItangSanjana commented
ItangSanjana’s picture

ItangSanjana CreditAttribution: ItangSanjana commented
FileSize
rooms-2145081-1.patch1.17 KB
ItangSanjana’s picture

ItangSanjana CreditAttribution: ItangSanjana commented

Oh my, its hard to match patch number with comment number!

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
CreditAttribution: jwilson3 commented
Status: Active » Reviewed & tested by the community
FileSize
rooms-unique-id-for-search-block-2145081-5.patch1.19 KB

I've pushed a fix to this to our internal rooms repo on github. Here is a version of the patch i've created.

Note that I haven't added any changes to the css, mainly because we've done a major overhaul of the css styles (trying to get rid of all the IDs and only use classes).

I'll attach the patch i used here, for posterity. i credited you in the commit message and will let you know when all this gets pushed to drupal.org

Thanks for finding this interesting bug!

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
CreditAttribution: jwilson3 commented

Marking this issue fixed because I've committed the patch to our internal repository at github. should make it into our next dev push to drupal.org when Ronald has a chance to review.

I need to create a follow up issue because this ajax id issue actually causes problems with synchronizing the date pickers, any time you have two or more availability search forms embedded in a page.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
CreditAttribution: jwilson3 commented

I created and patched the followup that should fix the similar issue for datepicker forms and I've refactored it such that two datepicker on a single page doesn't completely break things.

#2151565: Refactor rooms datepicker js code to avoid collisions

ItangSanjana’s picture

ItangSanjana CreditAttribution: ItangSanjana commented

Awesome! #5 did the trick.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
CreditAttribution: jwilson3 commented
Issue tags: +7.1

  • Commit 75ae265 on master, 7.x-1.x by jwilson3: 
    Issue #2145081 by iS, jwilson3: Duplicate id #rooms-wrapper.
ronald_istos’s picture

ronald_istos CreditAttribution: ronald_istos commented
Status: Reviewed & tested by the community » Fixed
ronald_istos’s picture

ronald_istos CreditAttribution: ronald_istos commented
Status: Fixed » Closed (fixed)