Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
when the block is activated, and are in page /booking we will find duplicate #rooms-wrapper id. Work around is to configur the block Visibility settings or replace these attribute to class? For the latter, here is the patch.
Comment | File | Size | Author |
---|---|---|---|
#5 | rooms-unique-id-for-search-block-2145081-5.patch | 1.19 KB | jwilson3 |
#3 | rooms-2145081-1.patch | 1.17 KB | ItangSanjana |
Comments
Comment #1
ItangSanjana CreditAttribution: ItangSanjana commentedComment #2
ItangSanjana CreditAttribution: ItangSanjana commentedComment #3
ItangSanjana CreditAttribution: ItangSanjana commentedComment #4
ItangSanjana CreditAttribution: ItangSanjana commentedOh my, its hard to match patch number with comment number!
Comment #5
jwilson3I've pushed a fix to this to our internal rooms repo on github. Here is a version of the patch i've created.
Note that I haven't added any changes to the css, mainly because we've done a major overhaul of the css styles (trying to get rid of all the IDs and only use classes).
I'll attach the patch i used here, for posterity. i credited you in the commit message and will let you know when all this gets pushed to drupal.org
Thanks for finding this interesting bug!
Comment #6
jwilson3Marking this issue fixed because I've committed the patch to our internal repository at github. should make it into our next dev push to drupal.org when Ronald has a chance to review.
I need to create a follow up issue because this ajax id issue actually causes problems with synchronizing the date pickers, any time you have two or more availability search forms embedded in a page.
Comment #7
jwilson3I created and patched the followup that should fix the similar issue for datepicker forms and I've refactored it such that two datepicker on a single page doesn't completely break things.
#2151565: Refactor rooms datepicker js code to avoid collisions
Comment #8
ItangSanjana CreditAttribution: ItangSanjana commentedAwesome! #5 did the trick.
Comment #9
jwilson3Comment #11
ronald_istos CreditAttribution: ronald_istos commentedComment #12
ronald_istos CreditAttribution: ronald_istos commented