Unnecessary white space in session-active class in language.negotiation.inc

This can make other modules looking for that class harder.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

manfer’s picture

Status: Active » Needs review
FileSize
937 bytes
manfer’s picture

Version: 8.x-dev » 7.x-dev
Status: Needs review » Patch (to be ported)
FileSize
809 bytes

Same in drupal 7 in locale.inc

The last submitted patch, 1: drupal-2147321-1-unnecessary_space.patch, failed testing.

manfer’s picture

The last submitted patch, 1: drupal-2147321-1-unnecessary_space.patch, failed testing.

manfer’s picture

Version: 7.x-dev » 8.x-dev
Status: Patch (to be ported) » Needs review
manfer’s picture

Status: Needs review » Needs work

The last submitted patch, 2: drupal7-2147321-unnecessary_space.patch, failed testing.

manfer’s picture

The last submitted patch, 1: drupal-2147321-1-unnecessary_space.patch, failed testing.

The last submitted patch, 1: drupal-2147321-1-unnecessary_space.patch, failed testing.

manfer’s picture

manfer’s picture

Status: Needs work » Needs review
droplet’s picture

Status: Needs review » Needs work

Patch do not apply

droplet’s picture

Version: 8.x-dev » 7.x-dev
Issue tags: +Novice, +Quick fix

No more in D8

droplet’s picture

Status: Needs work » Needs review
jcovington’s picture

Is that whitespace actually, in some cases, necessary? So that the session-active class can be added to an element that in some cases may already have a class or classes associated with it?

Ex. class="some-class some-other-class session-active"

droplet’s picture

No, Drupal will add space into it :)

smussbach’s picture

Status: Needs review » Reviewed & tested by the community

I can confirm that the patch works at current dev.

David_Rothstein’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 7.x - thanks!

  • David_Rothstein committed 6cf3889 on 7.x
    Issue #2147321 by manfer: Fixed Unnecessary space in session-active...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.