Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When someone with normal user permissions edits a comment, then the time stamp for the comment is changed and 'New' label is shown for other users.
When someone with elevated privileges (I don't know exactly which ones yet) updates a comment, the time stamp is NOT changed and no 'New' label shown.
Original report
For me case https://drupal.org/node/2068471#new has shown as New today, but not in past days and all other follow up comments are not new. This is date-wise impossible.
Screenshot: https://drupal.org/files/issues/2013-12-01_114347.png
Comment | File | Size | Author |
---|---|---|---|
#4 | before-editing.png | 51.13 KB | eliza411 |
#4 | new-after-update.png | 52.8 KB | eliza411 |
Comments
Comment #1
hass CreditAttribution: hass commentedTest save
Comment #2
tvn CreditAttribution: tvn commentedThis happens when the comment was edited. Not sure if we want to 'fix' this or leave as is. It might be helpful to notify people that the comment changed.
Comment #3
hass CreditAttribution: hass commentedNope. The time and date is still the same. This means the comment was NOT edited by the user. That's why I reported it. Otherwise the comment would have a date 1. december, but it's not.
Comment #4
eliza411 CreditAttribution: eliza411 commentedThe date displayed on a comment is the Post date, and it doesn't change when an issue is edited. I'm not saying that's how it *should* work, since a "New" flag doesn't at all describe what's happened with the comment.
[edit: checking timestamp again]
Comment #5
hass CreditAttribution: hass commentedThis is not correct. See my comment #1 that I just saved half a minute ago. The comment date will be updated to the last comment save timestamp. Aside I'm not talking about the issue date only zhe comment date as you can see in the screenshot, too.
Comment #6
eliza411 CreditAttribution: eliza411 commentedTesting "Posted" date on an edited comment when the comment is added using the full Issue update form. There is no issue summary change on this comment.
Comment #7
eliza411 CreditAttribution: eliza411 commentedThis comment was generated December 8 at 4:28 because the issue summary was updated and so resembles Comment #1. I expect that the timestamp for this edit may get updated like Comment #1.
Comment #8
eliza411 CreditAttribution: eliza411 commentedI am also talking only about the comment date.
I can see that you're having a different experience than I am. Comment #1 DOES shows an updated time stamp exactly as you've described, but when I update comments, the time stamp is NOT updated.
Attempt 1 to get the timestamp of a comment to update
I posted the Comment #4 at December 8, 2013 at 3:27pm
December 8, 2013 at 4:19pm I clicked the edit link for comment #4, added the text [edit: checking timestamp] and clicked "Save"
Comment #4 was now flagged as "New" but continued to show the comment post time: 3:27, even after clearing the browser cache.
Attempt 2 to get the timestamp of a comment to update
I triggered an automatic comment creation by updating the main issue because that's the kind of comment I was seeing for Comment #1. When I updated the comment, it still didn't change the time stamp.
Next, I'm going to try to reproduce the updated time stamp behavior as a user with different permissions.
Comment #9
git-peon CreditAttribution: git-peon commentedTesting the behavior of the comment date as a different user.
This was originally posted by git-peon on December 8, 2013 at 4:44pm new
Comment #10
eliza411 CreditAttribution: eliza411 commentedWhen someone with normal user permissions updates a comment, then the time stamp IS changed.
Sure enough, when someone with elevated privileges (I don't know exactly which ones yet) updates a comment, the time stamp is NOT changed.
That explains the random appearance of "New" flags and why it's not as obvious.
Comment #11
hass CreditAttribution: hass commented#4 has 9th december now... Maybe you have seen a caching delay that goes away after a few seconds... And than show the updated date?
Comment #12
tvn CreditAttribution: tvn commentedThanks for investigating, eliza411. Updated the summary per your last comment and added tag.
Comment #13
dokumori CreditAttribution: dokumori commentedComment #14
tvn CreditAttribution: tvn commentedComment #15
dokumori CreditAttribution: dokumori commentedThis is reported as a bug in the core #1374090: Editing a comment still changes creation date. Fixed for D8 and needs porting to D7