In /inc/form.inc in the function zurb_foundation_form_alter() there is a list of "ignored forms" stored in the array $forms_ids.

I was expecting that these forms would ignore the settings from that admin UI, including the tooltip setting, but it only tests for the theme wrapper.

Is this intentional or an oversight? In my case it was precisely the tooltips that I wanted to override (that is, I have the theme settings set to render help text as tooltips in most cases, but want some exceptions).

I suppose the real question is should I post a patch so that tooltip settings are also ignored on ignored forms, or does it currently work as designed?

Comments

kevinquillen’s picture

kevinquillen CreditAttribution: kevinquillen commented
Status: Active » Needs review
chrisjlee’s picture

chrisjlee CreditAttribution: chrisjlee commented

Post a patch and we can discuss the change.

kevinquillen’s picture

kevinquillen CreditAttribution: kevinquillen commented
Status: Needs review » Postponed (maintainer needs more info)

Awaiting patch.

kevinquillen’s picture

kevinquillen CreditAttribution: kevinquillen commented
Status: Postponed (maintainer needs more info) » Closed (works as designed)

Not sure what the issue is here anymore... feel free to reopen.

ergophobe’s picture

ergophobe CreditAttribution: ergophobe commented

This ends up being a bit more complicated than I was thinking, so the "Closed (works as designed)" is a good status for this one unless someone else wants something.