It would be nice to be able to control the preload attribute for audio and video tags in the field formatters.

CommentFileSizeAuthor
#9 2150679-preload.patch4.87 KBDave Reid
#8 2150679-preload.patch4.8 KBDave Reid
#3 file_entity-audio-video-preload-attr-support-2150679-3.patch5.07 KBrecrit
#2 file_entity-audio-video-preload-attr-support-2150679-2.patch1.7 KBrecrit
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Issue summary: View changes
recrit’s picture

recrit CreditAttribution: recrit commented
Status: Active » Needs review
FileSize
file_entity-audio-video-preload-attr-support-2150679-2.patch1.7 KB

The attached patch adds support for the preload attribute to audio and video themes.

recrit’s picture

recrit CreditAttribution: recrit commented
FileSize
file_entity-audio-video-preload-attr-support-2150679-3.patch5.07 KB

Updated patch: adds settings to the audio and video field formatters.

madhaze’s picture

madhaze CreditAttribution: madhaze commented
Status: Needs review » Active

Thanks for the patch, I will be testing this one soon.

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
CreditAttribution: jurgenhaas commented

I have tested the patch from #3 which is working just fine.

recrit’s picture

recrit CreditAttribution: recrit commented
Status: Active » Reviewed & tested by the community

switch back to the current status.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Reviewed & tested by the community » Needs work 
+++ b/file_entity.theme.inc
@@ -96,6 +96,12 @@ function theme_file_entity_file_audio($variables) {
+  if ($variables['preload']) {
+    $preload_value = drupal_strtolower($variables['preload']);
+    if (in_array($preload_value, array('none', 'auto', 'metadata'), FALSE)) {
+      $audio_attributes['preload'] = $preload_value;
+    }
+  }

Because the possible options are limited, I say let's remove this "validation" since it just adds extra effort when it's not necessary.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Needs work » Needs review
FileSize
2150679-preload.patch4.8 KB

Simplified theme versions.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
FileSize
2150679-preload.patch4.87 KB

Patch which makes 'unspecified' the default option, as to not change existing implementations. I think this is fairly safe considering that mobile browsers do not pre-fetch by default if the attribute is not defined.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Needs review » Fixed

Committed #9 to 7.x-2.x.

  • Dave Reid committed b6f4951 on 7.x-2.x 
    Issue #2150679 by recrit, Dave Reid: Added the ability to for change the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.