Submission limits, both in total and per user, can be set to negative numbers, which make no sense, and zero, which is not needed because forms should be closed if one does not want any submissions. Webform should verify that the limit is a positive integer.

CommentFileSizeAuthor
#1 webform_2150877_submission_limit.patch1.81 KBLiam Morland
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Liam Morland’s picture

Liam Morland
Primary language English
Location Ontario, CA 🇨🇦
CreditAttribution: Liam Morland commented
Status: Active » Needs review
FileSize
webform_2150877_submission_limit.patch1.81 KB
Liam Morland’s picture

Liam Morland
Primary language English
Location Ontario, CA 🇨🇦
CreditAttribution: Liam Morland commented
Title: Submission limits should always be greater than 1 » Submission limits should always be greater than zero
quicksketch’s picture

quicksketch
he/him
CreditAttribution: quicksketch commented
Status: Needs review » Fixed

Thanks again Liam. Looks great to me. Committed and pushed to 7.x-4.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
CreditAttribution: fenstrat commented
Version: 7.x-4.x-dev » 8.x-4.x-dev
Assigned: Unassigned » fenstrat
Status: Closed (fixed) » Patch (to be ported)

Needs porting to 8.x-4.x.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
CreditAttribution: fenstrat commented
Version: 8.x-4.x-dev » 7.x-4.x-dev
Assigned: fenstrat » Unassigned
Status: Patch (to be ported) » Fixed

Committed and pushed 41433bc to 8.x-4.x. Thanks!

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
CreditAttribution: fenstrat commented

Also committed and pushed 34af81c to 8.x-4.x.

  • Commit ddd353b on 8.x-4.x authored by Liam Morland, committed by fenstrat: 
    Issue #2150877 by Liam Morland: Submission limits should always be...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.