Convert theme_system_admin_index() to Twig

Split from system module twig conversion meta.

Patch applied with fuzz only, rerolled.

Postponed on #2151107: Convert theme_system_compact_link() to Twig

Why postponing this? It uses that theme but doesn't have any conflicts between them I'm pretty sure?

All the fails in #4 were related to system_compact_link, and I thought that was why - maybe not?

Seems like somehow it got applied to the wrong part of hook_theme(), and I didn't spot that earlier. Sorry!

No worries, at least you found what it was. That is strange it would do that, I wonder if one of the hunks is so similar that when head moved they magically lined up?

Profile of all 3 patches and confirmed they were all on the page.
#2151107-1: Convert theme_system_compact_link() to Twig
#2151105-7: Convert theme_system_admin_index() to Twig
#2151089-11: Convert theme_admin_block() to Twig

Scenario

• /admin/index as front page.
• Full permissions to all users.

=== 8.x..8.x compared (53195a48b6f09..53195b6957e56):

ct  : 141,571|141,571|0|0.0%
wt  : 699,947|697,654|-2,293|-0.3%
cpu : 694,237|691,839|-2,398|-0.3%
mu  : 32,653,568|32,653,568|0|0.0%
pmu : 32,751,144|32,751,144|0|0.0%

http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=53195a48b6f09&...

=== 8.x..2151089-theme_system compared (53195a48b6f09..53195bb0cc668):

ct  : 141,571|143,024|1,453|1.0%
wt  : 699,947|703,391|3,444|0.5%
cpu : 694,237|697,723|3,486|0.5%
mu  : 32,653,568|33,003,928|350,360|1.1%
pmu : 32,751,144|33,095,584|344,440|1.1%

http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?run1=53195a48b6f09&...

Here's the manual testing for this. The raw output from /admin/index is in the text files.

Beginning and end

Divs around the admin_blocks

That is already removed in #2151089: Convert theme_admin_block() to Twig, this will conflict if that patch is committed first.

Fixed #20. Also removed one unneeded array key - 'blocks' was the only thing inside the container, so we don't need it - and two unnecessary blank lines.

RTBC++

21: 2151105-twig-system_admin_index-21.patch queued for re-testing.

Back to RTBC, bot fluke:

Segmentation fault
FATAL Drupal\toolbar\Tests\ToolbarAdminMenuTest: test runner returned a non-zero error code (139).

I did commit that one, so marking this one needs work.

Re-rolled. Removed 'show'

diffed diffs:

--- from_file
+++ (clipboard)
@@ -1,8 +1,8 @@
 diff --git a/core/modules/system/system.admin.inc b/core/modules/system/system.admin.inc
-index 5789852..0e3cdcb 100644
+index 75f1c60..5fdfce0 100644
 --- a/core/modules/system/system.admin.inc
 +++ b/core/modules/system/system.admin.inc
-@@ -202,7 +202,9 @@ function theme_admin_page($variables) {
+@@ -150,7 +150,9 @@ function template_preprocess_admin_page(&$variables) {
  }
  
  /**
@@ -13,7 +13,7 @@
   *
   * @param $variables
   *   An associative array containing:
-@@ -210,55 +212,33 @@ function theme_admin_page($variables) {
+@@ -158,54 +160,32 @@ function template_preprocess_admin_page(&$variables) {
   *
   * @ingroup themeable
   */
@@ -46,7 +46,6 @@
 -      $block['title'] = $module;
 -      $block['content'] = drupal_render($admin_block_content);
 -      $block['description'] = t($description);
--      $block['show'] = TRUE;
 -
 -      $admin_block = array(
 +      $variables['containers'][$position][] = array(
@@ -55,7 +54,6 @@
 +        '#block' => array(
 +          'position' => $position,
 +          'title' => $module,
-+          'show' => TRUE,
 +          'content' => array(
 +            '#theme' => 'admin_block_content',
 +            '#content' => $items,
@@ -89,10 +87,10 @@
  
  /**
 diff --git a/core/modules/system/system.module b/core/modules/system/system.module
-index eef5bce..30da9fb 100644
+index ca908a2..b24428a 100644
 --- a/core/modules/system/system.module
 +++ b/core/modules/system/system.module
-@@ -209,6 +209,7 @@ function system_theme() {
+@@ -211,6 +211,7 @@ function system_theme() {
      'system_admin_index' => array(
        'variables' => array('menu_items' => NULL),
        'file' => 'system.admin.inc',

Doc updates.

I'm quick when I can smell RTBC:P

interdiff between #34 and #36

+++ b/core/modules/system/templates/system-admin-index.html.twig
@@ -0,0 +1,26 @@
+ * - containers: A list of administrative blocks keyed by position: left or
+ *   right. Each container contains:
+ *   - blocks: A list of blocks within a container.

Can we just remove from "Each container contains: ..."

The blocks are the containers.

I see that but block is just arbitrary name given to the value of the container. Maybe it would make more sense if we call the variable "containers" to "blocks" because all other ones were we do the "Each contains:" are properties on the object in the list. In this case the object is the "block" and it has no properties.

Here's what I mean, took from your #40 but tried to make it make scents, cents, and sense.

Well that shouldn't have failed it still applies with git apply and patch -p1.

Here's a re-roll just in case. Thanks for RTBC @Cottser:)

Committed and pushed to 8.x. Thanks!