Download formatter does not work with external files like youtube, vimeo and etc. [#2152323]

I use file entity together with media_youtube module and it seems that download formatter does not work well when I a user try to download a youtube video. Actually there is nothing to download and I think that correct behavior of the formatter will be to skip all the external files.

Comment	File	Size	Author
#5	download_formatter-2152323-4.patch	797 bytes	xcf33
#5
#5	download_formatter-2152323-3.patch	594 bytes	xcf33
#5
#2	download_formatter-2152323-2.patch	631 bytes	Devin Carlson
#2
#1	download_formatter-2152323-1.patch	626 bytes	boyan.borisov
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

boyan.borisov CreditAttribution: boyan.borisov commented 8 December 2013 at 11:55

Status:

Active

» Needs review

File	Size
download_formatter-2152323-1.patch	626 bytes

I've made a patch which will skip all the files with filesize == 0 from the download formatter.

Comment #2

Devin Carlson CreditAttribution: Devin Carlson commented 17 December 2013 at 18:52

File	Size
download_formatter-2152323-2.patch	631 bytes

Thanks for the patch!

We should be able to use the file_entity_file_is_local() function to determine if the file is local.

Comment #3

Devin Carlson CreditAttribution: Devin Carlson commented 17 December 2013 at 19:10

Status:

Needs review

» Fixed

Tested and confirmed that #2 restricted the download formatter to local files which resulted in it no longer being chosen to render remote files that can't be downloaded. I also checked to make sure that it would still be available to modules like Remote Stream Wrapper.

Committed #2 to File Entity 7.x-2.x.

Comment #4

xcf33 CreditAttribution: xcf33 commented 20 December 2013 at 20:43

I ran into similar issue with this but more so with the download link views handler,

I think a different approach to this would be to not only restrict (file_entity_file_is_local($file)) because there are many use cases where local file directory is not used (Amazon S3, Rackspace cloud files, etc)

I have attached 2 patches, one illustrate by using a simple hook we can allow modules to declare probably either schemes not allowed (youtube, vimeo, etc).

Comment #5

xcf33 CreditAttribution: xcf33 commented 20 December 2013 at 20:44

File	Size
download_formatter-2152323-3.patch	594 bytes

download_formatter-2152323-4.patch	797 bytes

Comment #6

xcf33 CreditAttribution: xcf33 commented 20 December 2013 at 20:45

1 file was hidden/shown/deleted

File	Size
download_formatter-2152323-3.patch	594 bytes

Comment #7

3 January 2014 at 20:50

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Comment #8

pianomansam CreditAttribution: pianomansam commented 29 May 2014 at 16:25

While the applied patch fixes the download link for external files, I'm not sure it does it the best way. I've discovered at least one bug that is caused by this patch - #2276437: External files using download formatter lose custom link text. Please see that issue with a different proposed patch that still fixes this issue but doesn't cause adverse side effects.