Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Part of #2152519: [meta] Make sure Drupal 8 looks good and works right on browsers (both mobile+desktop).
Remaining tasks
Needs testing.
| Comment | File | Size | Author |
|---|---|---|---|
| #26 | bartik-user-login-mobile-2152521-25.patch | 3.09 KB | prashantgoel |
| #26 | Screenshot_2014-08-11.png | 34.72 KB | prashantgoel |
| #21 | user-login-mobile.zip | 623.76 KB | Anonymous (not verified) |
| #20 | Screenshot_2014-06-01-15-13-25.png | 45.31 KB | mrjmd |
| #10 | Screenshot_2013-12-20-12-30-47.png | 52.59 KB | Manjit.Singh |
Comments
Comment #1
webchickComment #2
webchickAdditionally, the form spazzes out (er, well, zooms way in :)) when I click into a field.
Comment #3
LewisNymanIt's pretty simple to remove the input zooming on mobile, just up the font size to 16px.
I tried to keep the complexity of the responsive tabs design down. We could use some of the code in Seven from #1490402: Redesign tabs and the content header once it lands.
Comment #4
webchickWow, that looks MUCH better!!
Should we postpone this on the other, then? It seems like that one's pretty close.
Comment #5
LewisNymanOk. Now that I think about it, it would add a jQuery dependancy to all Bartik pages with tabs on. So it should be nod_'s call as to the approach.
Comment #6
webchickNo, no, no, no, no. :) In fact we have test coverage to ensure we do *not* load any JS on user-facing pages.
Comment #7
nod_well tabs are not present very often for anon (beside the login page) on websites so that should be fine. As long as you #attach the JS to the tab render element, nothing to complain about :)
Comment #8
webchickOh, ignore me then. :D
Comment #9
Manjit.SinghI have reviewed log-in page it looks fine now. Attaching screenshot
Comment #10
Manjit.SinghComment #11
sghoweri CreditAttribution: sghoweri commentedComment #12
sghoweri CreditAttribution: sghoweri commentedIs there a particular reason why the media query for shifting between using tabs and using 100% width buttons was set to the current 37.5em value?
I tested this out on the iPhone 5 with Safari for iOS (running iOS 7.0), the Stock Android Browser and Chrome for Android on the Samsung Galaxy S III (running Android 4.1.2), and Internet Explorer on the Nokia Lumina 920 (Windows Phone 8.0), all in portrait and landscape orientation.
Results:
iPhone 5 w/ iOS 7.0 in portrait orientation: GOOD
iPhone 5 - Portrait
iPhone 5 w/ iOS 7.0 in landscape orientation: N/A. Viewport zooms in (separate, unrelated issue)
iPhone 5 - Landscape
Samsung Galaxy S III - Chrome for Android in portrait orientation: GOOD
Galaxy S III - Chrome - Portrait
Samsung Galaxy S III - Stock Android Browser in portrait orientation: GOOD
Galaxy S III - Stock Android - Portrait
Windows Phone 8 - portrait orientation: GOOD
Windows Phone 8 - Portrait
Windows Phone 8 - landscape orientation: GOOD
Windows Phone 8 - Landscape
Samsung Galaxy S III - Chrome for Android in landscape orientation: Needs Work? Media Query for handling mobile tabs doesn't apply to wider mobile in landscape orientation.
Galaxy S III - Chrome - Landscape
Samsung Galaxy S III - Stock Android Browser in landscape orientation: Needs Work? Media Query for handling mobile tabs doesn't apply to wider mobile in landscape orientation.
Galaxy S III - Stock Android - Landscape
Comment #13
LewisNymanThanks for all the testing sghoweri! I tried to set the media query just before the tabs wrap and look all rubbish, see the screenshot in the issue summary.
Comment #14
LewisNymanSo right now #1490402: Redesign tabs and the content header is in and #2207371: Abstract the Seven tabs functionality for reusability is open. I get the feeling it's going to take a while to agree on the right approach for the tabs JS. Maybe it's worth committing what we have now as a temporary fix?
Comment #15
LewisNyman3: bartik-user-login-mobile-2152521.patch queued for re-testing.
Comment #17
emma.mariaComment #18
emma.mariaComment #19
mrjmd CreditAttribution: mrjmd commentedWorking on a reroll.
Comment #20
mrjmd CreditAttribution: mrjmd commentedI was able to apply this patch to HEAD without issue. Doesn't look like a reroll is needed.
Looks good on my mobile, screenshot attached.
Comment #21
Anonymous (not verified) CreditAttribution: Anonymous commentedHere's a wraith comparison (visual diff) of the patch against head. Looks like a small increase in size.
Comment #22
dcam CreditAttribution: dcam commentedI'm going to assume the Novice tag was added because #17 also thought it needed a reroll (I can also apply the patch to HEAD). Removing the Novice tag in preparation for the DrupalCon Austin sprints.
Comment #23
LewisNyman3: bartik-user-login-mobile-2152521.patch queued for re-testing.
Comment #24
emma.mariaThe patch no longer applies
Comment #25
dcam CreditAttribution: dcam commentedFixed the tag.
Comment #26
prashantgoel CreditAttribution: prashantgoel commentedHere is the reroll for the patch with a screenshot.
Comment #27
prashantgoel CreditAttribution: prashantgoel commentedComment #29
LoMo CreditAttribution: LoMo commentedReviewing. :-)
Comment #30
LoMo CreditAttribution: LoMo commentedLooking good to me, now. I think this can be marked RTBC. :-)
Device: Samsung Galaxy Note 2 (GT-N7105), running Android 4.3
Comment #31
webchickOh shoot, sorry. I thought I got this in last week. :(
Committed and pushed to 8.0.x. Thanks!