The current 7.x-3.x branch creates empty "help" regions if the "help" region is being rendered but there is no content. This can occur, for example, if a block is positioned in the region but its hook_block_view() implementation returns an empty array.

This patch adds the glyphicon only if there is content, so that the region is hidden if it is empty.

This bug was introduced in commit 994b110 from this issue: https://drupal.org/node/2100707

CommentFileSizeAuthor
bootstrap-empty-help-region.patch617 bytesezheidtmann
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Simon Georges’s picture

Simon Georges CreditAttribution: Simon Georges commented
Version: 7.x-3.0 » 7.x-3.x-dev

Patch still applies cleanly on 3.x version.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell commented
Status: Needs review » Fixed

Thanks @ezheidtmann!

Committed 2041f32 to 7.x-3.x:

Issue #2153409 by ezheidtmann: Don't create an empty "help" region .

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell commented

Committed 55b2253 to 7.x-3.x:

Issue #2153409 by ezheidtmann: Don't create an empty "help" region .

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

  • Commit 2041f32 on 7.x-3.x, 8.x-3.x authored by ezheidtmann, committed by Mark Carver: 
    Issue #2153409 by ezheidtmann: Don't create an empty "help" region .
  • Commit 55b2253 on 7.x-3.x, 8.x-3.x by Mark Carver:
    Issue #2153409 by ezheidtmann: Don't create an empty "help" region .
ryan.armstrong’s picture

ryan.armstrong CreditAttribution: ryan.armstrong commented
Version: 7.x-3.x-dev » 8.x-3.x-dev
Assigned: ezheidtmann » ryan.armstrong
Status: Closed (fixed) » Needs review

Moving this to the 8.x-3.x branch as it has been committed to that branch. Making sure the fix gets tested in the Drupal 8 release.

  • Mark Carver committed 2041f32 on 8.x-3.x.x authored by ezheidtmann 
    Issue #2153409 by ezheidtmann: Don't create an empty "help" region .
  • Mark Carver committed 55b2253 on 8.x-3.x.x
    Issue #2153409 by ezheidtmann: Don't create an empty "help" region .
markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell commented
Version: 8.x-3.x-dev » 7.x-3.x-dev
Assigned: ryan.armstrong » Unassigned
Status: Needs review » Closed (fixed)

I'm just moving this back to 7.x. If this needs re-evaluation in 8.x, create a new issue.