Form_state values in _webform_render_component implementations [#2153723]

Hi,

I have developed new module for Webform - Webform Multiple File. Module provides new webform component, that allows users to upload multiple files. I know, that exist Webform Multiple File Upload, but the goal of my module - it works in Drupal way without JS and external libraries. Design of my module similar to file field widget, that allows correct validation and file processing.

During development of Webform Multiple File I found bug #2153695: Incorrect key for component_value set. Also it's necessary to deliver data about uploaded files in implementation of _webform_render_component() every time during element rendering. I tried to find method without patching Webform module, but it's seems to be unreal. And I decided to add one new line in webform.module.

With this patch every implementation of _webform_render_component() will receive components value from $form_state in $value parameter. Patch doesn't break any common webform component and provides more flexibility.

Correct me, please, if I'm wrong. I really want to publish my module :)

Comment	File	Size	Author
#3	webform_current_value-2153723.patch	1.65 KB	quicksketch
#3
#1	webform-component-data-2153723.patch	761 bytes	Chalk
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Chalk CreditAttribution: Chalk commented 10 December 2013 at 14:13

File	Size
webform-component-data-2153723.patch	761 bytes

Comment #2

Chalk CreditAttribution: Chalk commented 21 January 2014 at 10:57

Hi,

Is there any news, questions?

Comment #3

quicksketch

he/him

CreditAttribution: quicksketch commented 16 February 2014 at 03:21

Status:

Needs review

» Fixed

File	Size
webform_current_value-2153723.patch	1.65 KB

The basic effect of this patch was already addressed in #1215456: Multiple and same-page conditional rules. Your patch has this state:

     $data = isset($submission->data[$cid]['value']) ? $submission->data[$cid]['value'] : NULL;
+    $data = isset($component_value) ? $component_value : $data;

But in Webform 4.x this line is now:

    $data = isset($input_values[$cid]) ? $input_values[$cid] : NULL;

Essentially, the same thing as your patch. However this brings up that we really should be using $component_value anyway, but $input_values[$cid] is the same as $component_value anyway. I've committed this patch which further cleans up our use of $input_values vs. $component_value. Functionally it makes no difference but increases the consistency of where we use which variables.

For Webform 3.x, I don't think we're going to making this change, as its data model is a bit more fragile and I'm worried about what problems would cause. This effectively may result in an unexpected API change. I'd recommend you simply have your module required Webform 4.x.

I'm marking this "fixed" since it's already working in Webform 4.x, but for 3.x, this is really "won't fix".