Regression: Contextual links broken, tabs erroneously added after enabling content translation module

The route exist, but afaics, the check in getDerivativeDefinitions() in ContentTranslationContextualLinks.php should be harder.

Looking at content_translation_entity_info_alter(), the 'translation' is added always, but the 'drupal:content-translation-overview' only gets added when there's a canonical URL. However, we only do an isset() on the translation key and that always will be true.

Now, I'm not even sure if this is safe enough as it's entirely possible someone else could alter into the content_translation array and adds more stuff. So maybe an !empty($entity_info['translation']['links']['drupal:content-translation-overview']) ?

Ah, right, the fact that I saw that tab was indeed confusing me after just enabling the module :)
I'll check both, either this evening, or over the weekend.

@gabor extremely limited in time in december - as early as mid january actually ...

@pwolanin found also

Uncaught PHP Exception Drupal\Component\Plugin\Exception\PluginException: "Contextual link plugin (content_translation.contextual_links:menu_link) definition must include "route_name"." at /Users/Shared/www/drupal-8/core/lib/Drupal/Core/Menu/ContextualLinkManager.php line 115

I can find the same with "tail /Applications/MAMP/logs/php_error.log" (found the error log location by checking phpinfo.php

in firebug:

watchdog entry:

Notice: Undefined index: drupal:content-translation-overview in Drupal\content_translation\Plugin\Derivative\ContentTranslationContextualLinks->getDerivativeDefinitions() (line 57 of /Users/ctheys/foo/drupal2/core/modules/content_translation/lib/Drupal/content_translation/Plugin/Derivative/ContentTranslationContextualLinks.php).

I got that yesterday, but a fresh reinstall solved it.

+++ b/core/modules/content_translation/lib/Drupal/content_translation/Plugin/Derivative/ContentTranslationContextualLinks.php
@@ -50,13 +50,11 @@ public static function create(ContainerInterface $container, $base_plugin_id) {
-      if ($entity_info['translatable'] && isset($entity_info['translation'])) {

huh, there are special content translation contextual links.

so.. this takes out the if?

Rebased patch after #2005716: Promote EntityType to a domain object got in.

Fixed the test failure and started working on a test. For some reason the contextual link is not yet showing up in the test, I am still missing something.

Going to work on this.

Was missing the "translate any entity" permission in the test. This one should be green.

The test is not very optimal, I was lazy and extended ContentTranslationTestBase which does a lot of unrelated stuff which makes this test rather slow. I will make a leaner version of the test.

Rewrote the test.

Before:

$ time sudo -u http php run-tests.sh --url http://drupal.local/ --class "\Drupal\content_translation\Tests\ContentTranslationContextualLinksTest"

Drupal test run
---------------

Tests to be run:
 - Content translation contextual links (\Drupal\content_translation\Tests\ContentTranslationContextualLinksTest)

Test run started:
 Friday, January 10, 2014 - 14:49

Test summary
------------

Content translation contextual links 67 passes, 0 fails, and 0 exceptions

Test run duration: 1 min 19 sec


real	1m20.141s
user	0m43.560s
sys	0m0.677s

After:

$ time sudo -u http php run-tests.sh --url http://drupal.local/ --class "\Drupal\content_translation\Tests\ContentTranslationContextualLinksTest"

Drupal test run
---------------

Tests to be run:
 - Content translation contextual links (\Drupal\content_translation\Tests\ContentTranslationContextualLinksTest)

Test run started:
 Friday, January 10, 2014 - 15:37

Test summary
------------

Content translation contextual links 17 passes, 0 fails, and 0 exceptions

Test run duration: 20 sec


real	0m20.457s
user	0m10.437s
sys	0m0.320s

From 1m20s to 20s, nice improvement :)

Unassigning myself, work here is complete. Reviews welcome!

Certainly. I still have half an hour before our glorious New Year Winter Barbeque™, hopefully will be able to make some progress in that time.

Ok so there is something interesting going on here. Apparently $entity_info->isTranslatable() is always TRUE, even if translations have been disabled in the interface. At least for nodes this is the case.

I have no time left to work on this today unfortunately.

Great work!

Committed and pushed to 8.x. Thanks!

@Gabor, regarding your question in #28. I have tested this in the latest 8.x and it occurs for all entities. I have opened an issue about it: #2188675: "Translate" local task always visible, leads to WSOD.