Problem/Motivation
1. Enable content translation module.
2. Now you'll have a translate tab on an article you create. Although no configuration on articles to be translatable. And no fields are translatable. (This is being resolved in #2154701: Regression: Contextual links broken, tabs erroneously added after enabling content translation module).
3. The no fields translatable button leads to the field UI list page for the content type, where its pretty darn hard to configure each field one by one to be translatable. We have a nice all-in-one screen for that now. (To be resolved here).
Proposed resolution
The link should lead to a better place.
Remaining tasks
Do it.
User interface changes
Button goes to more useful place.
API changes
None.
Comment | File | Size | Author |
---|---|---|---|
#6 | interdiff.txt | 1.29 KB | Gábor Hojtsy |
#6 | content-translation-fields-6.patch | 2.68 KB | Gábor Hojtsy |
Translate | s081ffd522ea3f80.s3.simplytest.me 2013-12-11 18-18-24.png | 69.83 KB | Gábor Hojtsy |
Comments
Comment #1
Gábor HojtsyAttached patch solves only problem 2 for now.
Comment #3
Gábor HojtsyRescoped now that we found out tabs have the same bug that contextual links and are to be fixed in #2154701: Regression: Contextual links broken, tabs erroneously added after enabling content translation module then. Only the "no fields" link is in scope here.
Comment #4
Gábor HojtsyThe overall page requires admin languages permission, so let's give that to the admin.
Comment #5
tim.plunkettAh, this confused me greatly when I was manually testing in other issues, I'm glad it wasn't just me!
Might as well switch this to \Drupal::currentUser()->hasPermission('administer languages'); while you're here.
Can we also switch this to use the route name?
Comment #6
Gábor HojtsyThanks! This should fix those two concerns. Looks good? :)
Comment #7
klonosComment #8
penyaskitoSummary up to date. #5 addressed, manual testing looks OK. RTBCing then.
Comment #9
tim.plunkettNope, RTBC +1!
Comment #10
webchickCommitted and pushed to 8.x. Thanks!
Comment #11
Gábor HojtsyYay, thanks!