Updates to the Migrate API (in v 7.x.2.5 I believe) force you to declare the migration field class.

Patch coming.

CommentFileSizeAuthor
#1 2155749-migrate-name.patch334 bytesagentrickard
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard commented
Status: Active » Needs review
FileSize
2155749-migrate-name.patch334 bytes

Simple patch.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

Could the name field type get away with not even having a field handler defined now that Migrate attempts to provide handlers for all field types that don't have a specific handler?

Alan D.’s picture

Alan D. CreditAttribution: Alan D. commented

Also #1468010: Name field support, from migrate extras, so should this be dropped altogether from the name module?

Related #1734922: Name Field Migrate support with import example (single full name text field separated and split into the individual components)

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard commented

I would prefer having it here, personally. It's part of the field definition. Pushing it to Migrate Extra seems odd to me.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard commented

It matter little to me. I was able to register the class in my custom migration module.

@Dave Reid

I don't think the generic handler will help, since the array structure needs to be set. I needed this handler.

Dane Powell’s picture

Dane Powell CreditAttribution: Dane Powell commented
Status: Needs review » Reviewed & tested by the community
Related issues: +#2221717: Improve and de-dupe migrate handler

This patch is required by #2221717: Improve and de-dupe migrate handler.

The default migrate field handler doesn't adequately handle name fields. The version in Migrate Extras works okay, but best practices is to provide this handler with the parent module, hence the need for #2221717: Improve and de-dupe migrate handler.

Dane Powell’s picture

Dane Powell CreditAttribution: Dane Powell commented
Status: Reviewed & tested by the community » Postponed

Actually, because the class name changes in that issue, we should just fix this there.

Alan D.’s picture

Alan D. CreditAttribution: Alan D. commented
Status: Postponed » Closed (duplicate)

@Dane Powell
The other is rtbtc, but not reviewing these in detail again. So flagging as a duplicate and closing, but reopen if there are followups required. Cheers