Project redirect error

@tvn(or other person with that access): Can you please try to reproduce this on production and copy paste here the associated watchdog messages?

Sure:

Recoverable fatal error: Argument 2 passed to drupal_goto() must be an array, string given in drupal_goto() (line 686 of /var/www/drupal.org/htdocs/includes/common.inc).

In fact, it's the same message as here #2155647: Error instead of 404 on nonexistent project page

Now can be reproduced on git7site as well:
https://git7site.devdrupal.org/project/opigno%2520video%2520app/git-inst...

@tvn: Not sure what is happening.

After some debug_backtrace(), I ended up with this trace:

Array
(
    [0] => Array
        (   
            [function] => drupal_goto
            [args] => Array
                (   
                    [0] => download
                    [1] => opigno-video-app
                    [2] => git-instructions
                )

        )

    [1] => Array
        (   
            [file] => /var/www/git-dev.drupal.org/htdocs/includes/menu.inc
            [line] => 517
            [function] => call_user_func_array
            [args] => Array
                (   
                    [0] => drupal_goto
                    [1] => Array
                        (   
                            [0] => download
                            [1] => opigno-video-app
                            [2] => git-instructions
                        )

                )

        )

    [2] => Array
        (   
            [file] => /var/www/git-dev.drupal.org/htdocs/index.php
            [line] => 21
            [function] => menu_execute_active_handler
            [args] => Array
                (
                )

        )

)

I do not really know why /project/opigno-video-app/git-instructions path is being called with download as first parameter.

Looking around I see hook_menu_alter() on drupalorg_project(), maybe it is related with it? not sure really, but seems unrelated with versioncontrol module.

Committed http://drupalcode.org/project/drupalorg.git/commit/9475b00 for this and deploying.

Since the project short name isn't found, the menu system falls back to the project page, and passes along the remaining path elements, which drupal_goto can't handle.

Actually, we don't even want any of these customizations, a basic redirect will do.

http://drupalcode.org/project/drupalorg.git/commit/3960db2 removes our altering of the menu item, which is removed by http://drupalcode.org/project/project_solr.git/commit/646de4c.

Now actually deploying.