Support prepareRollback and completeRollback on table destination [#2158661]

I don't know if there's any reason this isn't supported right now, but I feel like it should be. Patch coming right quick.

Comment	File	Size	Author
#1	tablerollback-2158661-1.patch	1.75 KB	chellman
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

chellman CreditAttribution: chellman commented 17 December 2013 at 20:15

Status:

Active

» Needs review

File	Size
tablerollback-2158661-1.patch	1.75 KB

Comment #2

13rac1 CreditAttribution: 13rac1 commented 14 March 2014 at 01:54

Status:

Needs review

» Needs work

Looks good. Any reason we wouldn't want it further up in MigrateDestination? Seems like it could be useful elsewhere? Correct me, if I am wrong! I haven't used MigrateDestinationTable myself yet.

Comment #3

mikeryan

he/him

English

Murphysboro, IL, USA

CreditAttribution: mikeryan commented 22 April 2014 at 20:23

Agreed with @eosrei - looking at this, the prepare(Rollback) and complete(Rollback) methods could have default implementations in MigrateDestination, and the existing implementations could call the parent method for the basic call-the-migration-class functionality.