Live Reload - Chrome Crashing [#2158823]

In running live reload I've ran into multiple issues with Chrome crashing should I have the inspector open and after a while of just dealing with it I found that there's a relatively simple solution for it all. I found this solution at #2148717: Chrome (Chromium) crashes when using livereload and the element inspector which changes the css from being imported to being linked. This helps Chrome deal with them better. Offering up a patch that when the live-reload is turned on it changes this over to allow for compatibility.

Hope this helps others!

Comment	File	Size	Author
#7	livereload-2158823-7.patch	638 bytes	Cellar Door
#1	livereload-2158823-2.patch	644 bytes	Cellar Door

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Cellar Door CreditAttribution: Cellar Door commented 18 December 2013 at 02:17

Assigned:	Unassigned	» fubhy
Issue summary:	View changes

File	Size
livereload-2158823-2.patch	644 bytes

Attaching the patch

Comment #2

Cellar Door CreditAttribution: Cellar Door commented 18 December 2013 at 02:33

Issue summary:

View changes

late in the day and after re-reading I realized I had import and link swapped in my description. It changes everything to being imported rather than linked so it handles better.

Comment #3

Cellar Door CreditAttribution: Cellar Door commented 18 December 2013 at 04:42

Issue summary:

View changes

Sheesh - I've got 3 comments on my own issue! Long day brain tired and I realized I was right the first time. Imports become links which allow Chrome to work with them instead of crashing. This is what the live reload module does just no need for the module with what we're doing. K - I'm done before I have to post another comment on my own issue :)

Comment #4

C13L0 CreditAttribution: C13L0 commented 22 December 2013 at 06:59

Thanks for this patch!

Comment #5

fubhy CreditAttribution: fubhy commented 22 December 2013 at 10:58

Status:

Active

» Needs work

+++ b/omega/template.php
@@ -280,6 +280,16 @@ function omega_css_alter(&$css) {
+  ¶

Empty whitespace on line 284.

+++ b/omega/template.php
@@ -280,6 +280,16 @@ function omega_css_alter(&$css) {
+  //than @import. This prevents crashing Chrome when using the inspector while
+  //livereload is enabled.

Please add a whitespace after the //.

+++ b/omega/template.php
@@ -280,6 +280,16 @@ function omega_css_alter(&$css) {
+  // When using omega_livereload orce CSS to be added with link tags, rather

"force" not "orce" :)

+++ b/omega/template.php
@@ -280,6 +280,16 @@ function omega_css_alter(&$css) {
+  if(omega_extension_enabled('development') && (omega_theme_get_setting('omega_livereload', TRUE)) {

In Drupal we have a whitespace between 'if' and the brackets.

+++ b/omega/template.php
@@ -280,6 +280,16 @@ function omega_css_alter(&$css) {
+  }
...
+    }
...
+      }
...
+        $css[$key]['preprocess'] = FALSE;
...
+      foreach ($css as $key => $value) {

The indentation looks weird there. Might be missing a closing curly bracket before this code block?