If the site name and site slogan options are unchecked from theme settings, I think it's better to not show them. I'm refering to <h1 id="site-title"> and <div id="site-description">

Otherwise they might create unneeded whitespace.

CommentFileSizeAuthor
#6 professional_theme-8.x-1.x-hide-site-slogan-2159761-6.patch959 bytesmfernea
#1 professional_theme-hide-site-slogan-2159761-1.patch959 bytesmfernea
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mfernea’s picture

mfernea CreditAttribution: mfernea commented
Status: Active » Needs review
FileSize
professional_theme-hide-site-slogan-2159761-1.patch959 bytes

I'm posting a patch for this.

mheinke’s picture

mheinke CreditAttribution: mheinke commented

thank you for the patch! reviewing now!

mheinke’s picture

mheinke CreditAttribution: mheinke commented

added to 7.x-2.x dev. please review (i gave you author credit :) ) thank you again!!

mfernea’s picture

mfernea CreditAttribution: mfernea commented

Tested again and everything looks good. Thanks! :)

I think we should wait for someone else to give the RTBC status.

mheinke’s picture

mheinke CreditAttribution: mheinke commented
Status: Needs review » Patch (to be ported)

it will be awhile before this is in the mainline, im going to move this into a "patch to be ported" status

mfernea’s picture

mfernea CreditAttribution: mfernea commented
Status: Patch (to be ported) » Needs review
FileSize
professional_theme-8.x-1.x-hide-site-slogan-2159761-6.patch959 bytes

I uploaded the patch for the 8.x-1.x branch.

mheinke’s picture

mheinke CreditAttribution: mheinke commented

8.x has been pushed with your patches. thanks!

mheinke’s picture

mheinke CreditAttribution: mheinke commented
Status: Needs review » Patch (to be ported)
mfernea’s picture

mfernea CreditAttribution: mfernea commented

Since the fix was merged in branches for both D7 and D8, I think the appropriate status would be "Fixed".

mheinke’s picture

mheinke CreditAttribution: mheinke commented

I will set status to "fixed" when this is in the stable release.

thanks!

mheinke’s picture

mheinke CreditAttribution: mheinke commented
Status: Patch (to be ported) » Closed (fixed)