Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
If the site name and site slogan options are unchecked from theme settings, I think it's better to not show them. I'm refering to <h1 id="site-title">
and <div id="site-description">
Otherwise they might create unneeded whitespace.
Comment | File | Size | Author |
---|---|---|---|
#6 | professional_theme-8.x-1.x-hide-site-slogan-2159761-6.patch | 959 bytes | mfernea |
#1 | professional_theme-hide-site-slogan-2159761-1.patch | 959 bytes | mfernea |
Comments
Comment #1
mfernea CreditAttribution: mfernea commentedI'm posting a patch for this.
Comment #2
mheinke CreditAttribution: mheinke commentedthank you for the patch! reviewing now!
Comment #3
mheinke CreditAttribution: mheinke commentedadded to 7.x-2.x dev. please review (i gave you author credit :) ) thank you again!!
Comment #4
mfernea CreditAttribution: mfernea commentedTested again and everything looks good. Thanks! :)
I think we should wait for someone else to give the RTBC status.
Comment #5
mheinke CreditAttribution: mheinke commentedit will be awhile before this is in the mainline, im going to move this into a "patch to be ported" status
Comment #6
mfernea CreditAttribution: mfernea commentedI uploaded the patch for the 8.x-1.x branch.
Comment #7
mheinke CreditAttribution: mheinke commented8.x has been pushed with your patches. thanks!
Comment #8
mheinke CreditAttribution: mheinke commentedComment #9
mfernea CreditAttribution: mfernea commentedSince the fix was merged in branches for both D7 and D8, I think the appropriate status would be "Fixed".
Comment #10
mheinke CreditAttribution: mheinke commentedI will set status to "fixed" when this is in the stable release.
thanks!
Comment #11
mheinke CreditAttribution: mheinke commented