After this point we need feature freeze for current 7.x-1.x-dev version with only bug and security fixes

Will upload patches for tests ina few days

CommentFileSizeAuthor
#6 2160675-6.patch23.49 KBpodarok
#6 interdiff-4.txt2.92 KBpodarok
#4 interdiff-2.txt378 bytespodarok
#4 2160675-4.patch21.98 KBpodarok
#3 interdiff-2.txt44.23 KBpodarok
#3 2160675-3.patch65.84 KBpodarok
#2 interdiff-1.txt20.38 KBpodarok
#2 2160675-2.patch22.05 KBpodarok
#1 2160675-1.patch6.07 KBpodarok
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented
Status: Needs work » Needs review
FileSize
2160675-1.patch6.07 KB

still needs work
do not commit yet please

bot testing

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented
FileSize
2160675-2.patch22.05 KB
interdiff-1.txt20.38 KB

progress

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented
FileSize
2160675-3.patch65.84 KB
interdiff-2.txt44.23 KB

woops
EDITED don`t looks at this...

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented
FileSize
2160675-4.patch21.98 KB
interdiff-2.txt378 bytes

here is a real patch without buggy includes

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented

#4 looks good for me and ready to be reviewed for commit
there are lot of todo`s I`m working on

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented
FileSize
interdiff-4.txt2.92 KB
2160675-6.patch23.49 KB

and ::saveRule implementation partially decoupled from css_injector_edit_save()
for unit testing we need rewrite $rule creation at all, cause drupal_write_record() not worked in testing environment

Status: Needs review » Needs work

The last submitted patch, 6: 2160675-6.patch, failed testing.