Add a form to delete orphaned line items [#2161121]

As the issue title says, let's fix this problem of orphaned line items at least with a form in the short term. Whoever picks this issue should ping rszrama to bikeshed the UI and confirm the batch process.

Comment	File	Size	Author
#5	commerce-2161121-orphan_line_items-5.patch	4.49 KB	czigor
#5	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 173 pass
#4	Screen Shot 2018-10-29 at 2.44.15 PM.png	21.98 KB	mglaman
#4	Screen Shot 2018-10-29 at 2.44.04 PM.png	25.07 KB	mglaman
#3	commerce-2161121-orphan_line_items-3.patch	4.55 KB	czigor
#3	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 173 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

rszrama CreditAttribution: rszrama at Centarro commented 18 October 2018 at 14:51

Issue summary:

View changes

Comment #2

rszrama CreditAttribution: rszrama at Centarro commented 18 October 2018 at 14:53

Issue summary:

View changes

Comment #3

czigor CreditAttribution: czigor at Centarro commented 29 October 2018 at 03:27

Status:

Active

» Needs review

File	Size
commerce-2161121-orphan_line_items-3.patch	4.55 KB
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 173 pass

Comment #4

mglaman

English

WI, USA

CreditAttribution: mglaman at Centarro commented 29 October 2018 at 19:44

File	Size
Screen Shot 2018-10-29 at 2.44.04 PM.png	25.07 KB
Screen Shot 2018-10-29 at 2.44.15 PM.png	21.98 KB

+++ b/modules/line_item/includes/commerce_line_item_ui.admin.inc
@@ -0,0 +1,103 @@
+    // Save node count for the termination message.

copy paste doc nit

Otherwise it works as expected:

Comment #5

czigor CreditAttribution: czigor at Centarro commented 29 October 2018 at 21:06

File	Size
commerce-2161121-orphan_line_items-5.patch	4.49 KB
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 173 pass

1 file was hidden/shown/deleted

File	Size
commerce-2161121-orphan_line_items-3.patch	4.55 KB
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 173 pass

Thanks Matt, removing that comment.

Comment #6

31 October 2018 at 18:19

rszrama committed d701429 on 7.x-1.x authored by czigor

Issue #2161121 by czigor, mglaman, rszrama: Add a form to delete...

Comment #7

rszrama CreditAttribution: rszrama at Centarro commented 31 October 2018 at 18:19

Status:

Needs review

» Fixed

I updated all language in this patch from "remove" to "delete" to make sure it's clear that we're actually deleting data. I also fixed a typo in the permission for the form callback, changing it from "administer line_items" to "administer line items."