Hi,
Could you please add the validation for indian phone numbers, If thats out of way for you I can provide the patch.

CommentFileSizeAuthor
#6 phone.in_.test1.18 KBnitvirus
#6 [Support-for-indian-numbers]-[2161669].patch705 bytesnitvirus
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
CreditAttribution: kscheirer commented
Title: Request for validation of Indian numbers » Support Indian numbers (including validation)
Version: 7.x-2.x-dev » 7.x-1.x-dev
Component: Miscellaneous » Code
Priority: Normal » Major

They're probably going to need a patch! India should definitely be supported, there is quite a lot of Drupal going on there.

I notice India is listed in countries.txt, but doesn't actually seem to be supported in the phone_countries() list.

The above is in reference to phone-7.x-1.x, I haven't check out the differences to 7.x-2.x yet. But I think Indian support should be able to go right into the 1.x branch without having to wait on 2.x.

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
CreditAttribution: kscheirer commented

After taking a look at 7.x-2.x the quickest solution for indian support is still a quick patch against 7.x-1.x.

However, the 7.x-2.x branch is based on a more mature PHP library that already supports India, so making that version of the module operational is a much better strategy.

nitvirus’s picture

nitvirus CreditAttribution: nitvirus commented

what I understand is: I can use the 7.x-2.x branch for india support.

For 7.x-1.x branch should I make a patch?

Thanks,
Nitish

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
CreditAttribution: kscheirer commented

nitvirus, if you have time I'm sure the maintainers would welcome a patch for 7.x-1.x. Make sure to set this issue to "needs review" when there is code available.

But to answer your question, the 7.x-2.x branch does support India already, but the module itself may not be finished yet.

nitvirus’s picture

nitvirus CreditAttribution: nitvirus commented
Assigned: Unassigned » nitvirus

Ok kscheirer,

I am assigning the issue to myself and would upload the patch soon.

Thanks. :D

nitvirus’s picture

nitvirus CreditAttribution: nitvirus commented
FileSize
[Support-for-indian-numbers]-[2161669].patch705 bytes
phone.in_.test1.18 KB

Hi,

I have made a patch for support of Indian number.
Maybe its a noob question but:
How can I add phone.in.inc in "includes/" and phone.in.test in "test/" folder?

I am attaching the patch file as such and putting the issue to "needs review". But the module needs phone.in.inc file and phone.in.test, and I am unable to attach the 'phone.in.inc' should I comment the code here?

Thanks

nitvirus’s picture

nitvirus CreditAttribution: nitvirus commented
Status: Active » Needs review