Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
As title.
Comment | File | Size | Author |
---|---|---|---|
#8 | email_to_nsid-2162471-8.patch | 9.97 KB | lolandese |
#5 | email_to_nsid-2162471-5.patch | 13.18 KB | lolandese |
#3 | email_to_nsid-2162471-3.patch | 13.67 KB | lolandese |
#1 | email_to_nsid-2162471-1.patch | 10.45 KB | lolandese |
Comments
Comment #1
lolandese CreditAttribution: lolandese commentedThe function flickr_user_find_by_identifier takes care of converting a username or email into a valid NSID (user identifier). It is used by the blocks but on the Flickr settings page submitting an email address resulted in:
The attached patch:
flickr_user_find_by_username
withflickr_user_find_by_identifier
except in the last function itself (so it is still needed). Now also an email address is accepted on the settings page.Thanks.
Comment #2
lolandese CreditAttribution: lolandese commentedTO DO:
Comment #3
lolandese CreditAttribution: lolandese commentedReroll against the latest dev.
Added Field names for block related error messages.
We did not extend to the user edit page that already accepts email, username and NSID as identifiers. Because they are also stored in all forms, using the NSID only as done for the blocks and default Flickr user would potentially break existing sites.
We took the opportunity to give the blocks more consistent and logical names but only in the block admin page, not the block titles themselves.
Comment #4
lolandese CreditAttribution: lolandese commentedTO DO:
Test behaviour on an existing site. Does it break something when upgrading?
Comment #5
lolandese CreditAttribution: lolandese commentedReroll. In block config human readable user ID did not appear (NSID instead) if no default user ID was given in Flickr settings.
Corrected.
Comment #6
lolandese CreditAttribution: lolandese commentedExisting blocks remain unaltered until opening their config page. This seems like acceptable behaviour as the user ID that is existing will be accepted as new input.
http://drupalcode.org/project/flickr.git/commitdiff/fb4a822
Comment #7
lolandese CreditAttribution: lolandese commentedComment #8
lolandese CreditAttribution: lolandese commentedComment #9
lolandese CreditAttribution: lolandese commentedhttp://drupalcode.org/project/flickr.git/commitdiff/2ba0380