Problem/Motivation

The template.php file has lots of inline code additions that should be moved to a separated file in order to be clean and easily maintainable.

Proposed resolution

  1. Move the frontpage slideshow code to a separated file called slideshow.js
  2. Update drupal_add_js to call a file instead of adding an inline code.
  3. Fix Drupal JavaScript coding standards issues.

@see https://drupal.org/node/172169 and https://drupal.org/node/1720586

CommentFileSizeAuthor
#3 simplecorp-move_slideshow_to_saparated_file-2163081-3.patch6.3 KBrevagomes
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

revagomes’s picture

revagomes CreditAttribution: revagomes commented
Title: Move frontpage slideshow code from its own file. » Move frontpage slideshow code from template.php to its own file.
revagomes’s picture

revagomes CreditAttribution: revagomes commented
Issue summary: View changes
revagomes’s picture

revagomes CreditAttribution: revagomes commented
Status: Active » Needs review
FileSize
simplecorp-move_slideshow_to_saparated_file-2163081-3.patch6.3 KB

Here goes the patch.

johnhanley’s picture

johnhanley CreditAttribution: johnhanley commented

I'm planning to use this nice theme for a new project, but I too find the code related to the slideshow (i.e. part of template.php) cumbersome.

This patch makes perfect since to me. What's the status of rolling it into the next release?

donapis’s picture

donapis CreditAttribution: donapis commented
Status: Needs review » Reviewed & tested by the community