corrected troll.install to run update.php, patch attached.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mgifford’s picture

Why did you nix function troll_update_7003 to "Support IPv6 address lengths." - but you moved that functionality up to troll_update_7001 and it never really supported IPv6 anyways from what I can tell.

I do think that could cause some confusion for folks who have already installed the dev release of this module.

The patch seems to work fine. It's better to use the DB API rather than direct mysql queries for sure.

Thanks!

mgifford’s picture

Title: instal fails on update.php » install fails on update.php
mgifford’s picture

Status: Active » Needs review
FileSize
3.41 KB

I don't know why the numbering in the install doesn't follow the troll_update_7001() format, but in git it doesn't.

I inserted the changes though into the git repo.

Never mind. I was on the wrong branch.

mgifford’s picture

This is a patch against the accurate git repo that builds on @ctmattice1's patch, but retains a the whitelist code in troll_update_7003 rather than just integrating it in 7001.

mgifford’s picture

Status: Needs review » Closed (fixed)

Fixed - commit f112b39d4fbe757c48052d81314e8418f2e902e4