Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
corrected troll.install to run update.php, patch attached.
Comment | File | Size | Author |
---|---|---|---|
#4 | install-troll-2164687-4.patch | 3.63 KB | mgifford |
#3 | install-troll-2164687-3.patch | 3.41 KB | mgifford |
install.patch | 3.56 KB | ctmattice1 |
Comments
Comment #1
mgiffordWhy did you nix function troll_update_7003 to "Support IPv6 address lengths." - but you moved that functionality up to troll_update_7001 and it never really supported IPv6 anyways from what I can tell.
I do think that could cause some confusion for folks who have already installed the dev release of this module.
The patch seems to work fine. It's better to use the DB API rather than direct mysql queries for sure.
Thanks!
Comment #2
mgiffordComment #3
mgiffordI don't know why the numbering in the install doesn't follow the troll_update_7001() format, but in git it doesn't.I inserted the changes though into the git repo.Never mind. I was on the wrong branch.
Comment #4
mgiffordThis is a patch against the accurate git repo that builds on @ctmattice1's patch, but retains a the whitelist code in troll_update_7003 rather than just integrating it in 7001.
Comment #5
mgiffordFixed - commit f112b39d4fbe757c48052d81314e8418f2e902e4