I just completed an install of a freshly packaged Commons 7.x-3.x to test the updated Media integration. Overall, this branch is looking great!

Here's some feedback on what we should probably improve before the next release. All testing was performed on Mac OS 10.8.5 with Google Chrome Version 31.0.1650.63.

A) Inline Media assets are visible when displaying a node but not when editing it. As an example when editing a Wiki node with an embedded image:

When viewing a node:
Only local images are allowed.
When editing the node:
Only local images are allowed.

B) When uploading fielded media assets, let's configure the node body to display above the media asset so that we provide some context for the media assets (aka the node content) when they're displayed in teaser format.
It would be ideal to always display at least one media asset regardless of the length of the node body content. It would be most ideal to display a grid of media assets along with the teaser to make it easier to see at a glance which assets are included in the node.

Here's an example node with the current display (node body text below media asset). Also, likely an unrelated themeing nitpick, but I would expect the "Following" button to appear atop the teaser along with the post metadata.
Only local images are allowed.

C) Embedding or uploading an image file is a multi step process. It may be out of scope of Commons/Media integration and instead within the scope of Media module in general, but it seems ideal to eliminate some of the steps since from my perspective the current multi-step process has enough steps to start to feel a bit cumbersome.

D) When uploading a file that exceeds the upload limit, the modal simply refreshes as if I never uploaded anything, forcing me to figure out what went wrong. Let's display a message inside the modal and ideally do a form_set_error to let folks know what went wrong.

E) We currently have a bit of a delta between the short form's UI for adding Media and what's implemented in Commons. I know this is intentional, but let's start mapping a path to bringing the upload controls that bring up the modal closer to the proposed sketches:

Currently in dev:

Proposed sketch (I should have posted this earlier for public review):

In general, fielded and inline Media uploading and embedding seem to work great in both nodes and comments, which is exciting! It's great to see this functionality taking shape in Commons :).

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ezra-g’s picture

Issue summary: View changes
ezra-g’s picture

Issue summary: View changes
FunkMonkey’s picture

Ezra, your sketch certainly looks like a nicer way to provide a +Media button. My instance currently shows the +Media button above the Body text box. Might just be something I did though.

I noticed that that the Commons Media says it is currently using Media 1.3. Will that be updated to Media 2.x at some point? I had tried to implement something similar myself earlier and I have Media 2.3 alpha in there I believe. Seems to be working fine so far.

I was also curious if this release was supposed to include the ability to add inline media in CKEditor? Or will that come in a followup release?

Thanks for all the work guys. Looks great!

lsolesen’s picture

Category: Support request » Feature request
Issue tags: -commons 7.x-3.7 radar