site_name_url without clean url [#2168363]

Comment	File	Size	Author
#3	wetkit_omega-more_flexible_site_name_url-2168363-3.patch	554 bytes	Anonymous (not verified)
#3	default_front_page.png	8.19 KB	Anonymous (not verified)

Comment #1

Anonymous (not verified) CreditAttribution: Anonymous commented 17 January 2014 at 16:20

same problem happen when a site is installed in a subfolder as the code is hardcoding '/'. Here's a patch with the fix from #1, but with the command shortened as the parameters in url() are not required to get the homepage.

Log in or register to post comments

Comment #2

sylus CreditAttribution: sylus commented 17 January 2014 at 17:14

Don't see the patch?

Can you also confirm that when specifying a full url in 'Site information' page that that still works?

For instance http://www.google.com.

Log in or register to post comments

Comment #3

Anonymous (not verified) CreditAttribution: Anonymous commented 17 January 2014 at 20:48

File	Size
default_front_page.png	8.19 KB
wetkit_omega-more_flexible_site_name_url-2168363-3.patch	554 bytes

sorry, seems like d.o thought I was a spammer for a while and blocked me.

in Site Information, with the patch it's working if one enter "node/1" or something similar, not working if one enter "http://google.com", it's by design, as the help text for the "default front page" field state "specify a relative URL to display as the front page". Current code is not working either for a full url btw.

Side note, current code have the weird side effect of creating the link for the homepage as "example.com/en/node/1", when other links to on the website will link to "example.com/en/", thus having two different url for the same page. this is not happening with this simple patch

Log in or register to post comments

Comment #4

sylus CreditAttribution: sylus commented 18 January 2014 at 23:29

Status:

Active

» Needs work

Yeah I have problems with honeypot as well. ^_^

We did use to override this field so that an external url could be used but was never a fan of that.

I'd take this patch but what just a quick question.

Say a user wants to override the front page and assign it to node/6 in the site information page.

This would no longer work with the patch just specifiying url.

Maybe we can instead check if that variable is empty then assign url() so both scenarios work?

Log in or register to post comments

Comment #5

sylus CreditAttribution: sylus commented 19 January 2014 at 22:25

I am thinking about just using the following?

Can you confirm that this works for the problem mentioned here?

$variables['site_name_url'] = variable_get('site_frontpage', 'node');

I just took away the bracket, this is also how Drupal core handles this.

Log in or register to post comments

Comment #6

sylus CreditAttribution: sylus commented 19 January 2014 at 22:31

I have committed this as should fix clean url issue.

I'll this issue open for feedback.

Commit: http://drupalcode.org/project/wetkit_omega.git/commit/b357bac

Log in or register to post comments

Comment #7

sylus CreditAttribution: sylus commented 19 January 2014 at 22:31

Status:

Needs work

» Postponed (maintainer needs more info)

Log in or register to post comments

Comment #8

sylus CreditAttribution: sylus commented 19 January 2014 at 22:32

Status:

Postponed (maintainer needs more info)

» Needs review

Log in or register to post comments

Comment #9

sylus CreditAttribution: sylus commented 19 January 2014 at 23:37

Nevermind I had to use the first patch and wrap inside url();

Seems to work for all my testing.

Commit: http://drupalcode.org/project/wetkit_omega.git/commit/677730d

Log in or register to post comments

Comment #10

Anonymous (not verified) CreditAttribution: Anonymous commented 20 January 2014 at 14:25

Thanks for the commit, these 3 lines are equivalent anyway and serving our project well

<?php
url(variable_get('site_frontpage', 'node'));
url('<front>');
url();
?>

setting something like "node/48" as the frontpage will work in all cases, as the function will return "example.com/en" and display the content of node/48 when the page is accessed.