Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.In some recent revision, we lost the "Please enter some keywords" message.
You get it if you search without keywords from the Search block, but not from search/node.
Noticed when testing #1126688: Allow users to use advanced search without keywords entered on latest 8.x.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 2170411-yuck.patch | 2.56 KB | jhodgdon |
Comments
Comment #1
jhodgdonI'm getting the message on the User search tab but not the Node search tab.
Comment #2
jhodgdonOK. I've tracked this down... What happens is that for User search, \Drupal\search\Form\SearchPageForm::submitForm() is called as the submit function, and that does the "please enter some keywords" message if there isn't anything there. But for Node search, \drupal\node\Plugin\Search\NodeSearch::searchFormSubmit() is called as the submit function, and that doesn't have the message.
I made a patch to fix this but it involves calling the deprecated form_set_error() function. Yuck. The problem is that NodeSearch is not a form builder so it doesn't have access to the form builder set error function.
Comment #3
jhodgdonWe need to redo how errors and warnings are handled in searching on #1366020: Overhaul SearchQuery; make search redirects use GET query params for keywords, which will hopefully take care of this problem, so I'm postponing this until that one is done.
Comment #4
jhodgdonThis was fixed and tested in #1366020: Overhaul SearchQuery; make search redirects use GET query params for keywords.