Got added in #1776166: Improve default language negotiation with no usages :) - there is still no usages after #1862202: Objectify the language system. Let's get rid.

CommentFileSizeAuthor
#2 2174827.2.patch916 bytesalexpott
d8.remove-language-detection-config.patch902 bytesalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, d8.remove-language-detection-config.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Needs work » Needs review
FileSize
2174827.2.patch916 bytes

Oops

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +language-base, +Quick fix

Indeed, the selected_language is stored in config('language.negotiation'), not language.detection. language.schema.yml is the only place language.detection is ever mentioned.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Nice catch!

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.