I'm getting "Theme hook advanced_help_topic not found." in my logs when testing this on simplytest.me. Pretty sure it's coming from:

$ grep -ir advanced_help_topic *
homebox.admin.inc: '#prefix' => theme('advanced_help_topic', array('module' => 'homebox', 'topic' => 'new-page')),
homebox.module: $output = '

' . theme('advanced_help_topic', array('module' => 'homebox', 'topic' => 'introduction')) . ' ';
homebox.module: $output = '

' . theme('advanced_help_topic', array('module' => 'homebox', 'topic' => 'default-layout')) . ' ';
homebox.module: $output = '

' . theme('advanced_help_topic', array('module' => 'homebox', 'topic' => 'settings')) . ' ';

Think we need something like this:

    $title = '';
    if (module_exists('advanced_help')) {
     $output = '<p>' . theme('advanced_help_topic', array('module' => 'homebox', 'topic' => 'settings')) . '&nbsp;';
    }
    $title .= '<p>' . t('Homebox advanced help') . '&nbsp;';

http://drupalcode.org/project/embed_views.git/commitdiff/20a06871268451d...

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Elin Yordanov’s picture

I've created a patch which checks if advanced_help module exists before using advanced_help_topic theme function.

Please review.

Elin Yordanov’s picture

Status: Active » Needs review
mgifford’s picture

Applies nicely locally. Code review looks good.

drumm’s picture

Assigned: Unassigned » drumm
Status: Needs review » Needs work

There actually aren't any .help.ini files, so I think these calls aren't useful even when advanced_help module does exist.

drumm’s picture

Status: Needs work » Fixed

  • drumm committed e8e6d50 on 7.x-2.x
    Issue #2175013: Remove advanced_help integration
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.