I'm getting "Theme hook advanced_help_topic not found." in my logs when testing this on simplytest.me. Pretty sure it's coming from:
$ grep -ir advanced_help_topic *
homebox.admin.inc: '#prefix' => theme('advanced_help_topic', array('module' => 'homebox', 'topic' => 'new-page')),
homebox.module: $output = '
' . theme('advanced_help_topic', array('module' => 'homebox', 'topic' => 'introduction')) . ' ';
homebox.module: $output = '
' . theme('advanced_help_topic', array('module' => 'homebox', 'topic' => 'default-layout')) . ' ';
homebox.module: $output = '
' . theme('advanced_help_topic', array('module' => 'homebox', 'topic' => 'settings')) . ' ';
Think we need something like this:
$title = '';
if (module_exists('advanced_help')) {
$output = '<p>' . theme('advanced_help_topic', array('module' => 'homebox', 'topic' => 'settings')) . ' ';
}
$title .= '<p>' . t('Homebox advanced help') . ' ';
http://drupalcode.org/project/embed_views.git/commitdiff/20a06871268451d...
Comment | File | Size | Author |
---|---|---|---|
#1 | advanced-help-topic-error-2175013-1.patch | 3.33 KB | Elin Yordanov |
Comments
Comment #1
Elin Yordanov CreditAttribution: Elin Yordanov commentedI've created a patch which checks if advanced_help module exists before using advanced_help_topic theme function.
Please review.
Comment #2
Elin Yordanov CreditAttribution: Elin Yordanov commentedComment #3
mgiffordApplies nicely locally. Code review looks good.
Comment #4
drummThere actually aren't any
.help.ini
files, so I think these calls aren't useful even when advanced_help module does exist.Comment #5
drumm