Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.#2171683: Remove all Simpletest overrides and rely on native multi-site functionality instead introduces a new configuration setting in simpletest.settings:
clear:
artifacts: true
# @todo Move into 'clear'.
clear_results: true
For consistency, clear_results should be moved into clear.results.
That said, perhaps one more bigger question is: Why is the clear.results setting exposed in the Simpletest settings UI?
I bet that everyone who toggles that option is actually seeking for the clear.artifacts option. What's the use-case of retaining the simpletest assertion results in the simpletest database tables?
| Comment | File | Size | Author |
|---|---|---|---|
| #31 | rename-2175151-31.patch | 4.96 KB | alansaviolobo |
| #27 | rename-2175151-27.patch | 4.86 KB | alansaviolobo |
| |||
| #25 | simpletest-clear-2175151.25.patch | 4.92 KB | larowlan |
Comments
Comment #1
sunComment #2
tstoecklerI guess this is postponed for now.
Comment #3
sunThis task is actually independent of the parent issue. There are conflicts in affected lines, but that's ok.
Attached patch renames the configuration key and goes ahead and removes the setting from the UI.
Comment #4
tstoecklerThis should be removed.
Not sure about removing the setting from the UI. Isn't it somewhat useful to compare the test results between consecutive runs? I agree it's not the coolest feature in the world but, ...
Comment #5
jibran3: drupal8.simpletest-clear-results.3.patch queued for re-testing.
Comment #7
sunComment #8
amateescu CreditAttribution: amateescu commentedI agree with @tstoeckler, why do we need to remove the option from the UI?
Comment #9
sunFrom the issue summary:
I bet I'm one of the advanced users of Simpletest facing the most advanced debugging scenarios that can possibly exist (because I'm developing Simpletest itself), and I never ever had a use-case for retaining/inspecting the test assertion results in the Simpletest module tables.
This setting pretty much only exists for (1)
SimpleTestTest(testing the test runner itself) and (2) PIFR/testbots.I'm happy to be convinced that I'm wrong, but in that case, please state that you have used this setting and you really would miss it in the UI (→ the run-tests.sh parameter is not removed)
Comment #10
amateescu CreditAttribution: amateescu commentedI bet != I know. That said, I'm curious how you plan to get everyone that ever used the simpletest module to state that they will never miss that option in the UI. For now, you only have two core developer who expressed their preference to not remove it.
Comment #11
sunOK, let's end this debate. I'll file a separate issue to remove it.
Attached patch retains the UI setting, but performs the same usability change as in #2176023: Allow to keep artifacts after a test run (test site + database); i.e., the checkbox value is negated, because a checkbox setting like this should never be enabled by default, but instead, the user is able to enable a behavior that diverges from the default behavior. Likewise, the label and description is vastly shortened for readability.
Comment #12
sunSorry, I also wanted to remove the added @todos, as they're irrelevant here. Will cancel the test for the previous patch in a moment.
Comment #15
sunComment #16
sun12: drupal8.simpletest-clear-results.12.patch queued for re-testing.
Comment #18
sunRe-rolled against HEAD.
Comment #20
sun18: drupal8.simpletest-clear-results.18.patch queued for re-testing.
Comment #21
sun18: drupal8.simpletest-clear-results.18.patch queued for re-testing.
Comment #23
tstoeckler18: drupal8.simpletest-clear-results.18.patch queued for re-testing.
Comment #25
larowlanre-roll
Comment #26
larowlanwhoops
Comment #27
alansaviolobo CreditAttribution: alansaviolobo commentedComment #31
alansaviolobo CreditAttribution: alansaviolobo commentedsorry. wrong patch uploaded earlier.
Comment #41
quietone CreditAttribution: quietone as a volunteer commentedTriaging issues in simpletest.module to determine if they should be in the Simpletest Project or core.
This looks like it a simpletest module issue, changing the project.