Motivation:
In a long task log it is sometimes a 'little' pain to find the warnings/errors.

The top right corner could have two links "First warning" and "First error" like the "First unread comment" in the issue queue.

This could either be done in JavaScript or as an html anchor

Additional thoughts:
* a summary of the number of warnings/errors...
* hovering 'skip to next' link

Comments

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
CreditAttribution: ergonlogic commented
Status: Active » Needs review

I've taken a first pass at this. It could be cleaned up in Eldir, and extended with the other suggestions...

helmo’s picture

helmo CreditAttribution: helmo at Initfour websolutions commented

Thanks, it works nice when viewing the task log as a whole page. However it's not working for me via the overlay.

The query part e.g. '?render=overlay' is then lost.

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
CreditAttribution: ergonlogic commented

This works for me with the overlay... I don't see a ?render=overlay query, though presumably we could build it back into the url.

helmo’s picture

helmo CreditAttribution: helmo at Initfour websolutions commented

In the address bar I see #overlay=hosting/task/282, but the iframe used in the overlay has the ?render=overlay query.

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
CreditAttribution: ergonlogic commented

Perhaps we need to add target="_parent" to the link, since that's the behaviour I'm seeing.

Though, linking within the iframe would probably be better. Perhaps we need request_path() instead of current_path().

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
CreditAttribution: ergonlogic commented

I switched to request_path(), and added target="_self". Could you pull in this latest commit, and try again?

helmo’s picture

helmo CreditAttribution: helmo at Initfour websolutions commented

No improvement here :(

Adding 'query'=> array('render' => 'overlay') to the options array does help.

I would expect drupal_get_query_parameters() to give us the current query, however I guess that the overlay module removes the render=overlay part.

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
CreditAttribution: ergonlogic commented

Ok, so now we set the query, depending on whether we're in an overlay child window or not.

helmo’s picture

helmo CreditAttribution: helmo at Initfour websolutions commented
Status: Needs review » Fixed

Great :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.