Migrating a year-only field fails [#2175749]

When you try to migrate a year-only date field, the migration differs exactly a month and one day. This is because strtotime(), used in Migrate API, cannot handle a string like 2012-00-00, which is what Date sends to Migrate if the month and day is empty. The fix is simple; just add a fake month and day to the year.

Comment	File	Size	Author
#6	date-year-only-fails-2175749-6.patch	701 bytes	mortona2k
#6
#2	2175749-migrating-year-only-fields.patch	493 bytes	BarisW
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

BarisW CreditAttribution: BarisW commented 17 January 2014 at 14:40

Status:

Active

» Needs review

Here's a patch. I'd wanted to add a test too, but the Date Migration tests seems to be broken?

Fatal error: Class 'Migrate' not found in date_migrate.test on line 54

Comment #2

BarisW CreditAttribution: BarisW commented 17 January 2014 at 14:40

File	Size
2175749-migrating-year-only-fields.patch	493 bytes

Comment #3

vijaycs85

London, UK

CreditAttribution: vijaycs85 commented 18 February 2014 at 11:52

Status:	Needs review	» Needs work
Issue tags:		+sprint, +Needs tests

Thanks for the patch @BarisW, but assuming 4 character value as year seems more specific and might introduce some other regressions.

Comment #4

pdesai CreditAttribution: pdesai commented 25 February 2015 at 18:44

Using Drupal Migrate UI to migrate from Drupal 6 to Drupal 7 (same server). Have a content type with a date field for year and it imports except 1996 would show up as 1995 in Drupal 7. I have tried to set the Timezone to "America/New_York" which is the site's time zone on both sites. I also tried leaving the timezone field blank, but same issue of being off by one year.

I applied the above patch but still no luck. Any idea what is configured incorrectly?

Comment #5

pdesai CreditAttribution: pdesai commented 17 March 2015 at 15:50

I was able to fix the issue by adding the following to the patch:

if (strlen($to) == 4) {
	$to .= '-01-01';
}
$from = str_replace('-00-00T00:00:00', '-01-01T00:00:00', $from);
$to = str_replace('-00-00T00:00:00', '-01-01T00:00:00', $to);

Comment #6

mortona2k CreditAttribution: mortona2k commented 5 November 2015 at 17:04

File	Size
date-year-only-fails-2175749-6.patch	701 bytes

This patch combines the two approaches above. The first will check for 4 digit year values (2014) and append '-01-01' to them. The second will take iso date values that only have a year such as 2014-00-00T00:00:00 and set it to 2014-01-01T00:00:00.

There may be a better way to handle the dates, but this seems to work.