D7 Masqueradedit

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Ran the project through http://pareview.sh/, a couple of minor issues:

There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732
Review of the 7.x-1.x branch:

Coder Sniffer has found some issues with your code (please check the Drupal coding standards).

FILE: /var/www/drupal-7-pareview/pareview_temp/README.txt
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
43 | WARNING | Line exceeds 80 characters; contains 97 characters
--------------------------------------------------------------------------------

DrupalPractice has found some issues with your code, but could be false positives.

FILE: /var/www/drupal-7-pareview/pareview_temp/masqueradedit.module
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
93 | WARNING | Unused variable $revision_uid_updated.
--------------------------------------------------------------------------------

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.
Source: http://pareview.sh/ - PAReview.sh online service

Hi MrDaleSmith,
I have check it on my local machine, it is working fine. I didn't find any bug though which is great!!!
:)

> 93 | WARNING | Unused variable $revision_uid_updated

Could this be avoided by not assigning the return value to anything? It would contain the number of rows affected, which isn't subsequently used.

Hi !

First of all, you can improve the git description in this topic by replacing:

http://drupalcode.org/sandbox/MrDaleSmith/2170047.git

by:

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/MrDaleSmith/2170047.git masqueradedit
cd masqueradedit

Concernning the README.txt file, it's good and very detailed. Concerning the tabs, I think you can warn user that they have to display tabs in their theme. It can happen that a theme hides or does not display tabs (or use custom links for admin/edit links).

When using it, it was working as designed. I think the default tab title should be "edit as author". With "edit as user" we don't understand which user it's about.

Moreover, I think it would be great to have this edit link in contextual links (for nodes teasers for example).

Concerning the code in the module, you should put the title in the hook_menu in t(), so that it's tranlatable.

That's all I see. Thanks for this module which can be really useful when you need to edit a node as the author.

Yes, you're right ! The callback defaults to t() as stated in there : https://api.drupal.org/api/drupal/modules%21system%21system.api.php/func...

Non-blocking issues:

• You can remove the .gitignore file
• I don't think you need the module_exists('masquerade') check in masqueradedit_access(). Since it's declared as a dependency, it will always be enabled when your module is running
• In masqueradedit_menu() it would be very cool if you used a title callback to dynamically set the tab title. Then if the author was user "johndoe" the tab would read "Edit as johndoe" and so forth.

Thanks for your contribution, MrDaleSmith!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.