'Hide blank items' setting doesn't work correctly.

I would recommend anybody who needs the fix to apply this patch, but it does not seem complete for 2 reasons.

- The description about Hide blank items is not accurate. It does not apply to "any multivalued field" as it states.

- The Hide blank items checkbox appears under the cardinality selector whenever a value other than 1 is chosen. It only makes sense for it to be there if "unlimited" is selected.

Many thanks both to plopesc and jmuzz for this.

Thanks for making the changes I requested plopesc.

I'm looking at this again and I'm not sure this is the right approach afterall. Isn't the default behavior for an unlimited cardinality field to start with a single blank item anyway? I don't see what the hide blank items option is supposed to do for them. It's limited cardinality fields that usually present several blank options on the form. Obviously the current behavior of hiding one blank item wrong, but maybe this option is supposed to work on limited cardinality fields and make them work more like unlimited cardinality fields where one blank item is presented with the option to add more.

If the option really does do something useful for unlimited cardinality fields then please explain and I think this can be committed.

I agree with plopesc, that there is an issue with the widget not displaying the correct number of fields when a fixed value is set.

With regards to the hide blank items option - I don't think that this applies to limited cardinality. I feel that this would probably be best in a separate issue as there is further discussion needed on this hide blank items option to whether there is any value in making use of this option when using limited cardinality or not.

The empty widget can mess up an entity form, and there's an issue about getting rid of them entirely. #1788222: Allow "add another" button instead of empty field collection item form when using the embedded widget . I don't think that's what this check box is trying to do. It doesn't seem to do anything to the unlimited cardinality fields. If it did remove the initial blank item that would provide an advantage, but as per the help text on the check box:

"A blank item is always added to any multivalued field's form. If checked, any additional blank items are hidden except of the first item which is always shown."

So the first blank item is always shown, which, for an unlimited cardinality field, is the only blank item until the user hits the add button. The help text only makes sense if it applies to a limited cardinality field, since those are the ones that have additional blank items. I think it would be a useful feature to have if (1) it really did hide all the blank items except for one instead of just removing one and (2) if there was an add button for the limited cardinality fields. A field collection can have many fields and sometimes a user can want to limit the number of field collection items entered without having several blank ones always appearing on the form.

I think this issue should be about fixing the behavior of this option on limited cardinality fields and implementing the add button for them. For removing the initial blank item on unlimited cardinality fields there is the other issue.

This patch will have it show only a single blank field collection item in a limited cardinality field. By submitting the form multiple times more can be added. A better solution would include the add more button.

You are right, I misunderstood what it meant by first blank field collection item. I thought it meant the first blank field collection item every time the form opened, but it really only applies if there are no values in the field collection yet and it actually is hiding that blank item if there are values there already.

Thanks plopesc.