Add a throbber to show the user when terms are loading via ajax [#2182143]

Comment	File	Size	Author
#7	shs-progress_indicator-2182143-7.patch	2.07 KB	ParisLiakos
#1	simple_hierarchical_select-shs-2182143-1.patch	2.2 KB	igorski
#2	shs-progress_indicator-2182143-2.patch	2.13 KB	igorski

Comment #1

igorski CreditAttribution: igorski commented 29 January 2014 at 12:23

File	Size
simple_hierarchical_select-shs-2182143-1.patch	2.2 KB

Please try the attached patch file. I’ve added a simple progress indicator to shs.js.
The inline CSS is definitely bad style, but it’s a start.

Log in or register to post comments

Comment #2

igorski CreditAttribution: igorski commented 29 January 2014 at 14:39

File	Size
shs-progress_indicator-2182143-2.patch	2.13 KB

1 file was hidden/shown/deleted

File	Size
simple_hierarchical_select-shs-2182143-1.patch	2.2 KB

A slightly better version which accounts for RTL themes.

Log in or register to post comments

Comment #3

vgutekunst CreditAttribution: vgutekunst commented 8 February 2014 at 10:25

Thanks i will test it! ;-)

Log in or register to post comments

Comment #4

vgutekunst CreditAttribution: vgutekunst commented 16 February 2014 at 20:57

hi thanks for this patch! It worked! The loading button now floats to the right. Is it possible to get him directly under or beneath the new field? Because i think the user dont see it when its in the left or right corner of the screen

Log in or register to post comments

Comment #5

Nikita Petrov CreditAttribution: Nikita Petrov commented 12 March 2014 at 11:42

#1 works great! Thank you, igorski.

Log in or register to post comments

Comment #6

rooby CreditAttribution: rooby commented 24 April 2014 at 05:15

Title:	No loading process showing	» Add a throbber to show the user when terms are loading via ajax
Assigned:	vgutekunst	» Unassigned
Category:	Bug report	» Feature request
Status:	Active	» Needs review

This patch is definitely an improvement.

As mentioned in #4 it would be nice if the throbber was directly to the right of the field instead of all the way to the right of the screen, but it is still very usable in its current state.

Log in or register to post comments

Comment #7

ParisLiakos CreditAttribution: ParisLiakos commented 2 June 2015 at 23:54

File	Size
shs-progress_indicator-2182143-7.patch	2.07 KB

i find it easier to notice when there is no float at all..
float right means that in the standard drupal node form and a big screen, you never notice the throbber :)
here is a patch with the float removed. The widget jumps now a bit, but imo at least it is noticeable now

Log in or register to post comments

Comment #8

ron_s CreditAttribution: ron_s commented 3 June 2015 at 02:40

A throbber is displayed by default using this patch to dispatch a change event:
https://www.drupal.org/node/2264795

Might want to check this one first, since the change event is needed to support other modules and States API.

Log in or register to post comments

Comment #9

ParisLiakos CreditAttribution: ParisLiakos commented 3 June 2015 at 03:51

I applied the patch there, but there was no throbber after changing a select element

Log in or register to post comments

Comment #10

ron_s CreditAttribution: ron_s commented 3 June 2015 at 05:22

That's odd, I did get one. Possible that something in the css is causing it to not display?

Log in or register to post comments

Comment #11

ParisLiakos CreditAttribution: ParisLiakos commented 3 June 2015 at 12:10

no, i dont see one even in the html source code..maybe another module you have installed?
i dont see how would a loader would be triggered though tbh just by a change event..
i think #states in Drupal7 have nothing to do with ajax, they are just plain jQuery commands that act on html thats already there

Log in or register to post comments

Comment #12

ron_s CreditAttribution: ron_s commented 3 June 2015 at 15:12

Yes, could be that the form is already wrapped in an ['#ajax'] that's causing it, I haven't tested.

So I'm assuming if the same was done to the SHS field in a hook_form_alter, it would cause a throbber to appear:

  $form['field_my_shs_select'][LANGUAGE_NONE]['#ajax'] = array(
    'callback' => '',  // can add one if you'd like, but not necessary if no other action
    'event' => 'change',
    'progress' => array(
      'type' => 'throbber',
      'message' => NULL,
    ),
  );

Should also mention that the event can be 'click' rather than 'change' too. I believe there are several possible options.