In block_schema(), the 'block' table, the column 'delta' currently is a varchar(32).
It is quite easy to hit this limit. Especially if the block delta is composed from different parts for disambiguation.
E.g. mymodule-footer_product_categories
(the block's module is "menupoly", not "mymodule")
Or #1512656: Block delta too long with some menus ("Better Jump Menus")
Or https://www.google.com/search?q=Data+too+long+for+column+'delta'+drupal+block&oq=Data+too+long+for+column+'delta'+drupal+block&sourceid=chrome&ie=UTF-8
Changing it from varchar(32) to varchar(64) would be an improvement already..
Comment | File | Size | Author |
---|---|---|---|
#6 | 2182201-block-delta-64-6.patch | 900 bytes | evilfurryone |
#4 | 2182201-block-delta-64-4.patch | 619 bytes | joshi.rohit100 |
#2 | 2182201-block-delta-64-2.patch | 450 bytes | joshi.rohit100 |
Comments
Comment #1
dcam CreditAttribution: dcam commentedI'm going to assume this doesn't apply to D8 since block information is no longer stored in the database. This should be a good Novice issue.
Comment #2
joshi.rohit100Done 32 => 64
Comment #3
dcam CreditAttribution: dcam commentedMy fault, I should have mentioned that this will need to have an update function.
Comment #4
joshi.rohit100Comment #5
dcam CreditAttribution: dcam commentedOk, once again I wasn't clear. Both of these changes are necessary. If you can give us a combined patch then I'll RTBC it. I'd do it, but I don't want to steal credit. I tested the combined changes and they're working correctly, on install and on update.
Comment #6
evilfurryone CreditAttribution: evilfurryone at Wunder commentedI merged the two patches into one.
Comment #7
vishwac9 CreditAttribution: vishwac9 as a volunteer commentedComment #8
dawehnerCompeting issue: #1223772: Extend the size of block.delta to 64
Comment #9
cilefen CreditAttribution: cilefen commentedOne of them is a duplicate. It is probably this one, because the other one is older.
Comment #10
David_Rothstein CreditAttribution: David_Rothstein as a volunteer commentedThat other issue looks further along since it also handles fixing an additional table that stores the block delta, so yeah, let's close this as a duplicate.